From: Qu Wenruo <wqu@suse.com>
To: Naohiro Aota <naohiro.aota@wdc.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/4] btrfs-progs: tests: check nullb index for the error case
Date: Wed, 10 Sep 2025 14:52:35 +0930 [thread overview]
Message-ID: <c54170d0-d3c7-4753-96c2-3ed4b497ab36@suse.com> (raw)
In-Reply-To: <20250910050412.2138579-3-naohiro.aota@wdc.com>
在 2025/9/10 14:34, Naohiro Aota 写道:
> "_find_free_index" can return "" when an error occur. Check the return
> value for the case and fail the test.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> tests/nullb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/nullb b/tests/nullb
> index f3cdf9c19e16..721da8f13f12 100755
> --- a/tests/nullb
> +++ b/tests/nullb
> @@ -146,6 +146,9 @@ fi
> if [ "$CMD" = 'create' ]; then
> _check_setup
> index=$(_find_free_index)
> + if [ -z "$index" ]; then
> + exit 1
> + fi
> name="nullb$index"
> # size in MB
> size=$(_parse_device_size "$@")
next prev parent reply other threads:[~2025-09-10 5:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 5:04 [PATCH v2 0/4] btrfs-progs: tests: add new mkfs test for zoned device Naohiro Aota
2025-09-10 5:04 ` [PATCH v2 1/4] btrfs-progs: tests: output error/warn message to stderr Naohiro Aota
2025-09-10 5:22 ` Qu Wenruo
2025-09-10 5:04 ` [PATCH v2 2/4] btrfs-progs: tests: check nullb index for the error case Naohiro Aota
2025-09-10 5:22 ` Qu Wenruo [this message]
2025-09-10 5:04 ` [PATCH v2 3/4] btrfs-progs: tests: add wait_for_nullbdevs Naohiro Aota
2025-09-10 5:22 ` Qu Wenruo
2025-09-10 5:04 ` [PATCH v2 4/4] btrfs-progs: tests: add new mkfs test for zoned device Naohiro Aota
2025-10-16 17:53 ` [PATCH v2 0/4] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c54170d0-d3c7-4753-96c2-3ed4b497ab36@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox