Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Filipe Manana <fdmanana@kernel.org>, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH v2 05/11] btrfs: remove extent_map::orig_start member
Date: Tue, 14 May 2024 07:44:48 +0930	[thread overview]
Message-ID: <6e8925b1-c492-4f5c-8143-b14fd97a0e12@gmx.com> (raw)
In-Reply-To: <CAL3q7H5fTGX0zJzzWepv2LdVYf2Vb_fBbBUhVZhhc4v8cXe8NA@mail.gmail.com>



在 2024/5/13 22:39, Filipe Manana 写道:
[...]
>> @@ -861,7 +857,7 @@ TRACE_EVENT(btrfs_add_block_group,
>>                  { BTRFS_DROP_DELAYED_REF,   "DROP_DELAYED_REF" },       \
>>                  { BTRFS_ADD_DELAYED_EXTENT, "ADD_DELAYED_EXTENT" },     \
>>                  { BTRFS_UPDATE_DELAYED_HEAD, "UPDATE_DELAYED_HEAD" })
>> -
>> +
>
> Unrelated white space change. Please avoid that.

That seems to be caused by clangd lsp server.

I have no idea why it automatically cleaned up the whitespace problems
every time I modified the header file.
And IIRC it's not the first time it's doing this.

I'd better find a way to disable the auto fix.

Thanks,
Qu
>
> Thanks.
>
>>
>>   DECLARE_EVENT_CLASS(btrfs_delayed_tree_ref,
>>
>> @@ -873,7 +869,7 @@ DECLARE_EVENT_CLASS(btrfs_delayed_tree_ref,
>>          TP_STRUCT__entry_btrfs(
>>                  __field(        u64,  bytenr            )
>>                  __field(        u64,  num_bytes         )
>> -               __field(        int,  action            )
>> +               __field(        int,  action            )
>>                  __field(        u64,  parent            )
>>                  __field(        u64,  ref_root          )
>>                  __field(        int,  level             )
>> @@ -930,7 +926,7 @@ DECLARE_EVENT_CLASS(btrfs_delayed_data_ref,
>>          TP_STRUCT__entry_btrfs(
>>                  __field(        u64,  bytenr            )
>>                  __field(        u64,  num_bytes         )
>> -               __field(        int,  action            )
>> +               __field(        int,  action            )
>>                  __field(        u64,  parent            )
>>                  __field(        u64,  ref_root          )
>>                  __field(        u64,  owner             )
>> @@ -992,7 +988,7 @@ DECLARE_EVENT_CLASS(btrfs_delayed_ref_head,
>>          TP_STRUCT__entry_btrfs(
>>                  __field(        u64,  bytenr            )
>>                  __field(        u64,  num_bytes         )
>> -               __field(        int,  action            )
>> +               __field(        int,  action            )
>>                  __field(        int,  is_data           )
>>          ),
>>
>> --
>> 2.45.0
>>
>>
>

  reply	other threads:[~2024-05-13 22:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03  6:01 [PATCH v2 00/11] btrfs: extent-map: unify the members with btrfs_ordered_extent Qu Wenruo
2024-05-03  6:01 ` [PATCH v2 01/11] btrfs: rename extent_map::orig_block_len to disk_num_bytes Qu Wenruo
2024-05-09 16:15   ` Filipe Manana
2024-05-03  6:01 ` [PATCH v2 02/11] btrfs: export the expected file extent through can_nocow_extent() Qu Wenruo
2024-05-09 16:22   ` Filipe Manana
2024-05-09 21:55     ` Qu Wenruo
2024-05-03  6:01 ` [PATCH v2 03/11] btrfs: introduce new members for extent_map Qu Wenruo
2024-05-09 17:05   ` Filipe Manana
2024-05-09 22:11     ` Qu Wenruo
2024-05-10 11:26       ` Filipe Manana
2024-05-10 22:26         ` Qu Wenruo
2024-05-13 12:48   ` Filipe Manana
2024-05-13 12:54     ` Filipe Manana
2024-05-13 17:31   ` Filipe Manana
2024-05-03  6:01 ` [PATCH v2 04/11] btrfs: introduce extra sanity checks for extent maps Qu Wenruo
2024-05-13 12:21   ` Filipe Manana
2024-05-13 22:34     ` Qu Wenruo
2024-05-03  6:01 ` [PATCH v2 05/11] btrfs: remove extent_map::orig_start member Qu Wenruo
2024-05-13 13:09   ` Filipe Manana
2024-05-13 22:14     ` Qu Wenruo [this message]
2024-05-03  6:01 ` [PATCH v2 06/11] btrfs: remove extent_map::block_len member Qu Wenruo
2024-05-13 17:44   ` Filipe Manana
2024-05-14  7:09     ` Qu Wenruo
2024-05-03  6:01 ` [PATCH v2 07/11] btrfs: remove extent_map::block_start member Qu Wenruo
2024-05-16 17:28   ` Filipe Manana
2024-05-16 22:45     ` Qu Wenruo
2024-05-03  6:01 ` [PATCH v2 08/11] btrfs: cleanup duplicated parameters related to can_nocow_file_extent_args Qu Wenruo
2024-05-20 15:55   ` Filipe Manana
2024-05-20 22:13     ` Qu Wenruo
2024-05-03  6:01 ` [PATCH v2 09/11] btrfs: cleanup duplicated parameters related to btrfs_alloc_ordered_extent Qu Wenruo
2024-05-20 16:31   ` Filipe Manana
2024-05-03  6:01 ` [PATCH v2 10/11] btrfs: cleanup duplicated parameters related to create_io_em() Qu Wenruo
2024-05-20 16:46   ` Filipe Manana
2024-05-03  6:01 ` [PATCH v2 11/11] btrfs: cleanup duplicated parameters related to btrfs_create_dio_extent() Qu Wenruo
2024-05-20 16:48   ` Filipe Manana
2024-05-23  4:03     ` Qu Wenruo
2024-05-03 11:53 ` [PATCH v2 00/11] btrfs: extent-map: unify the members with btrfs_ordered_extent David Sterba
2024-05-20 16:55 ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e8925b1-c492-4f5c-8143-b14fd97a0e12@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.com \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox