Re: [PATCH v2 06/11] btrfs: remove extent_map::block_len member

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2024/5/14 03:14, Filipe Manana 写道:
[...]
>> @@ -1098,8 +1088,6 @@ int split_extent_map(struct btrfs_inode *inode, u64 start, u64 len, u64 pre,
>>          split_pre->disk_num_bytes = split_pre->len;
>>          split_pre->offset = 0;
>>          split_pre->block_start = new_logical;
>> -       split_pre->block_len = split_pre->len;
>> -       split_pre->disk_num_bytes = split_pre->block_len;
>
> Ok so this relates to my comment on patch 3, which added the first
> ->disk_num_bytes assignment, a few lines above and visible in this
> diff, which was useless because of this one.
>
> This is hard to follow. Some patches add code just to be removed a few
> patches later.
>

Thankfully after addressing the comments in patch 3, this one is gone.

But indeed this is a big problem, I'll re-check the patches again
manually to ensure the deletion is only there when really needed.

Thanks,
Qu