From: Johannes Thumshirn <jthumshirn@suse.de>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: volumes: Refactor device holes gathering into a separate function
Date: Thu, 7 Nov 2019 10:20:42 +0100 [thread overview]
Message-ID: <77bcec95-5e72-092c-66f5-a0b3b6e08049@suse.de> (raw)
In-Reply-To: <20191107062710.67964-2-wqu@suse.com>
On 07/11/2019 07:27, Qu Wenruo wrote:
> +static int gather_dev_holes(struct btrfs_fs_info *info,
> + struct btrfs_device_info *devices_info,
> + int *index, struct list_head *list,
> + int max_nr_devs, u64 stripe_size, int dev_stripes)
> +{
Hi Qu,
What do you think of
static int gather_dev_holes(struct btrfs_fs_info *info,
int *index, u64 stripe_size,
int dev_stripes)
{
struct btrfs_fs_devices *fs_devices = info->fs_devices;
struct btrfs_device *device;
int ret;
int ndevs = 0;
list_for_each_entry(device, &fs_devices->alloc_list,
dev_alloc_list) {
[...]
btrfs_device_info can be derived from btrfs_fs_info, and *list and
max_nr_devs can be derived from btrfs_device_info.
This reduces the number of arguments by 3 and we don't need to pass that
odd 'struct list_head *list' which isn't really clear from the type what
it is referring to.
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-11-07 9:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 6:27 [PATCH 0/3] btrfs: More intelligent degraded chunk allocator Qu Wenruo
2019-11-07 6:27 ` [PATCH 1/3] btrfs: volumes: Refactor device holes gathering into a separate function Qu Wenruo
2019-11-07 9:20 ` Johannes Thumshirn [this message]
2019-11-07 9:33 ` Qu Wenruo
2019-11-07 9:45 ` Johannes Thumshirn
2019-11-07 6:27 ` [PATCH 2/3] btrfs: volumes: Add btrfs_fs_devices::missing_list to collect missing devices Qu Wenruo
2019-11-07 9:31 ` Johannes Thumshirn
2019-11-19 10:03 ` Anand Jain
2019-11-19 10:29 ` Qu Wenruo
2019-11-27 19:36 ` David Sterba
2019-11-07 6:27 ` [PATCH 3/3] btrfs: volumes: Allocate degraded chunks if rw devices can't fullfil a chunk Qu Wenruo
2019-11-19 10:05 ` Anand Jain
2019-11-19 10:41 ` Qu Wenruo
2019-11-27 19:23 ` David Sterba
2019-11-27 23:36 ` Qu Wenruo
2019-11-28 11:24 ` David Sterba
2019-11-28 12:29 ` Qu Wenruo
2019-11-28 12:30 ` Qu WenRuo
2019-11-28 12:39 ` Qu Wenruo
2019-11-18 20:18 ` [PATCH 0/3] btrfs: More intelligent degraded chunk allocator David Sterba
2019-11-18 23:32 ` Qu Wenruo
2019-11-19 5:18 ` Alberto Bursi
2019-11-27 19:26 ` David Sterba
2019-12-02 3:22 ` Zygo Blaxell
2019-12-02 4:41 ` Qu Wenruo
2019-12-02 19:27 ` Zygo Blaxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77bcec95-5e72-092c-66f5-a0b3b6e08049@suse.de \
--to=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox