From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: start deprecation of mount option inode_cache
Date: Wed, 24 Jun 2020 19:06:35 +0800 [thread overview]
Message-ID: <78e85a4d-2484-3e80-0347-85f7658f3a29@gmx.com> (raw)
In-Reply-To: <20200624110019.GP27795@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]
On 2020/6/24 下午7:00, David Sterba wrote:
> On Wed, Jun 24, 2020 at 07:27:46AM +0800, Qu Wenruo wrote:
>>> Remaining issues:
>>>
>>> - if the option was enabled, new inodes created, the option disabled
>>> again, the cache is still stored on the devices and there's currently
>>> no way to remove it
>>
>> What about "btrfs rescue remove-deprecated-feature inode_cache"?
>> I really don't want kernel to do the hassle.
>
> Most likely we'll need both, the kernel part is for cases where it's not
> so easy to access the filesystem unmounted to do the change. Like a root
> partition. How to do that to be least intrusive is the open.
>
OK. Then what about do it in btrfs_orphan_cleanup()?
It looks like a perfect match.
Thanks,
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-24 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 18:50 [PATCH] btrfs: start deprecation of mount option inode_cache David Sterba
2020-06-23 23:27 ` Qu Wenruo
2020-06-24 11:00 ` David Sterba
2020-06-24 11:06 ` Qu Wenruo [this message]
2020-06-24 7:37 ` Steven Davies
2020-06-24 9:55 ` David Sterba
2020-07-07 17:14 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e85a4d-2484-3e80-0347-85f7658f3a29@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox