Re: [PATCH v8 3/3] btrfs: create read policy sysfs attribute, pid

[Josef Bacik <josef@toxicpanda.com>]

On 10/20/20 10:02 AM, Anand Jain wrote:
> Add
> 
>   /sys/fs/btrfs/UUID/read_policy
> 
> attribute so that the read policy for the raid1, raid1c34 and raid10 can
> be tuned.
> 
> When this attribute is read, it shall show all available policies, with
> active policy being with in [ ]. The read_policy attribute can be written
> using one of the items listed in there.
> 
> For example:
>    $cat /sys/fs/btrfs/UUID/read_policy
>    [pid]
>    $echo pid > /sys/fs/btrfs/UUID/read_policy
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> rebase on latest misc-next
> v5:
>    Title rename: old: btrfs: sysfs, add read_policy attribute
>    Uses the btrfs_strmatch() helper (BTRFS_READ_POLICY_NAME_MAX dropped).
>    Use the table for the policy names.
>    Rename len to ret.
>    Use a simple logic to prefix space in btrfs_read_policy_show()
>    Reviewed-by: Josef Bacik <josef@toxicpanda.com> dropped.
> 
> v4:-
> v3: rename [by_pid] to [pid]
> v2: v2: check input len before strip and kstrdup
> 
>   fs/btrfs/sysfs.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
> 
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index eb0b2bfcce67..07a1a57b2df2 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -886,6 +886,54 @@ static int btrfs_strmatch(const char *given, const char *golden)
>   	return -EINVAL;
>   }
>   
> +static const char* const btrfs_read_policy_name[] = { "pid" };

This fails checkpatch.pl, it should be

static const char * const.  Thanks,

Josef