From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>, linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com
Subject: Re: [PATCH v8 3/3] btrfs: create read policy sysfs attribute, pid
Date: Thu, 22 Oct 2020 15:40:29 +0800 [thread overview]
Message-ID: <c5605c0d-b19a-d067-85cd-e7809f8b2963@oracle.com> (raw)
In-Reply-To: <78f8abc7-d7de-77be-6e4a-81beb683fced@toxicpanda.com>
>> @@ -886,6 +886,54 @@ static int btrfs_strmatch(const char *given,
>> const char *golden)
>> return -EINVAL;
>> }
>> +static const char* const btrfs_read_policy_name[] = { "pid" };
>
> This fails checkpatch.pl, it should be
>
> static const char * const. Thanks,
This is taken care in v9. Thanks.
Anand
>
> Josef
next prev parent reply other threads:[~2020-10-22 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 14:02 [PATCH v8 0/3] readmirror feature (read_policy sysfs and Anand Jain
2020-10-20 14:02 ` [PATCH v8 1/3] btrfs: add btrfs_strmatch helper Anand Jain
2020-10-21 14:44 ` Josef Bacik
2020-10-22 7:40 ` Anand Jain
2020-10-20 14:02 ` [PATCH v8 2/3] btrfs: create read policy framework Anand Jain
2020-10-21 14:46 ` Josef Bacik
2020-10-20 14:02 ` [PATCH v8 3/3] btrfs: create read policy sysfs attribute, pid Anand Jain
2020-10-21 14:42 ` Josef Bacik
2020-10-22 7:40 ` Anand Jain [this message]
2020-10-20 14:22 ` [PATCH v8 0/3] readmirror feature (read_policy sysfs and in-memory only approach) Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5605c0d-b19a-d067-85cd-e7809f8b2963@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox