From: Marcos Paulo de Souza <mpdesouza@suse.de>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
David Sterba <dsterba@suse.com>
Cc: Qu Wenruo <wqu@suse.com>,
"linux-btrfs @ vger . kernel . org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH misc-next] btrfs: fix compilation error in btree_write_cache_pages()
Date: Mon, 24 Feb 2020 18:30:38 -0300 [thread overview]
Message-ID: <795cb7cc9d36eb84c1ed03efdbb8702ef9282774.camel@suse.de> (raw)
In-Reply-To: <20200224202251.37787-1-johannes.thumshirn@wdc.com>
On Tue, 2020-02-25 at 05:22 +0900, Johannes Thumshirn wrote:
> CC [M] fs/btrfs/extent_io.o
> fs/btrfs/extent_io.c: In function ‘btree_write_cache_pages’:
> fs/btrfs/extent_io.c:3959:34: error: ‘tree’ undeclared (first use in
> this function); did you mean ‘true’?
> 3959 | struct btrfs_fs_info *fs_info = tree->fs_info;
> | ^~~~
> | true
> fs/btrfs/extent_io.c:3959:34: note: each undeclared identifier is
> reported only once for each function it appears in
> make[2]: *** [scripts/Makefile.build:268: fs/btrfs/extent_io.o] Error
> 1
> make[1]: *** [scripts/Makefile.build:505: fs/btrfs] Error 2
> make: *** [Makefile:1681: fs] Error 2
>
> Fixes: 75c39607eb0a ("btrfs: Don't submit any btree write bio if the
> fs has errors")
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Indeed, it fixes the build of misc-next.
Reviewed-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> ---
> fs/btrfs/extent_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 903a85d8fbe3..837262d54e28 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -3956,7 +3956,7 @@ int btree_write_cache_pages(struct
> address_space *mapping,
> .extent_locked = 0,
> .sync_io = wbc->sync_mode == WB_SYNC_ALL,
> };
> - struct btrfs_fs_info *fs_info = tree->fs_info;
> + struct btrfs_fs_info *fs_info = BTRFS_I(mapping->host)->root-
> >fs_info;
> int ret = 0;
> int done = 0;
> int nr_to_write_done = 0;
next prev parent reply other threads:[~2020-02-24 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 20:22 [PATCH misc-next] btrfs: fix compilation error in btree_write_cache_pages() Johannes Thumshirn
2020-02-24 21:30 ` Marcos Paulo de Souza [this message]
2020-02-24 23:28 ` David Sterba
2020-02-24 23:54 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795cb7cc9d36eb84c1ed03efdbb8702ef9282774.camel@suse.de \
--to=mpdesouza@suse.de \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox