From: Qu Wenruo <wqu@suse.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h
Date: Thu, 1 Oct 2026 18:35:15 +0930 [thread overview]
Message-ID: <7f63da46-e755-458c-b846-e5d555eb5169@suse.com> (raw)
In-Reply-To: <0be3914031faf9bf34dd86daf884e42f7352d848.1790785074.git.fdmanana@suse.com>
在 2026/10/1 01:48, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> There is no need to forward declare the structures as their definitions
> are brought in by the include of the linux/blkdev.h and fs.h files.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/volumes.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 337d7007d9e2..6eddda239221 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -24,9 +24,6 @@
> #include "extent-io-tree.h"
> #include "fs.h"
>
> -struct block_device;
> -struct bdev_handle;
> -struct btrfs_fs_info;
> struct btrfs_block_group;
> struct btrfs_trans_handle;
> struct btrfs_transaction;
next prev parent reply other threads:[~2026-10-01 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 16:18 [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h fdmanana
2026-10-01 9:05 ` Qu Wenruo [this message]
2026-10-01 11:27 ` Daniel Vacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f63da46-e755-458c-b846-e5d555eb5169@suse.com \
--to=wqu@suse.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox