* [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h
@ 2026-09-30 16:18 fdmanana
2026-10-01 9:05 ` Qu Wenruo
2026-10-01 11:27 ` Daniel Vacek
0 siblings, 2 replies; 3+ messages in thread
From: fdmanana @ 2026-09-30 16:18 UTC (permalink / raw)
To: linux-btrfs
From: Filipe Manana <fdmanana@suse.com>
There is no need to forward declare the structures as their definitions
are brought in by the include of the linux/blkdev.h and fs.h files.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/volumes.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index 337d7007d9e2..6eddda239221 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -24,9 +24,6 @@
#include "extent-io-tree.h"
#include "fs.h"
-struct block_device;
-struct bdev_handle;
-struct btrfs_fs_info;
struct btrfs_block_group;
struct btrfs_trans_handle;
struct btrfs_transaction;
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h
2026-09-30 16:18 [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h fdmanana
@ 2026-10-01 9:05 ` Qu Wenruo
2026-10-01 11:27 ` Daniel Vacek
1 sibling, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2026-10-01 9:05 UTC (permalink / raw)
To: fdmanana, linux-btrfs
在 2026/10/1 01:48, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> There is no need to forward declare the structures as their definitions
> are brought in by the include of the linux/blkdev.h and fs.h files.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/volumes.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 337d7007d9e2..6eddda239221 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -24,9 +24,6 @@
> #include "extent-io-tree.h"
> #include "fs.h"
>
> -struct block_device;
> -struct bdev_handle;
> -struct btrfs_fs_info;
> struct btrfs_block_group;
> struct btrfs_trans_handle;
> struct btrfs_transaction;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h
2026-09-30 16:18 [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h fdmanana
2026-10-01 9:05 ` Qu Wenruo
@ 2026-10-01 11:27 ` Daniel Vacek
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vacek @ 2026-10-01 11:27 UTC (permalink / raw)
To: fdmanana; +Cc: linux-btrfs
On Wed, 30 Sept 2026 at 18:30, <fdmanana@kernel.org> wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> There is no need to forward declare the structures as their definitions
> are brought in by the include of the linux/blkdev.h and fs.h files.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Daniel Vacek <neelx@suse.com>
> ---
> fs/btrfs/volumes.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 337d7007d9e2..6eddda239221 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -24,9 +24,6 @@
> #include "extent-io-tree.h"
> #include "fs.h"
>
> -struct block_device;
> -struct bdev_handle;
> -struct btrfs_fs_info;
> struct btrfs_block_group;
> struct btrfs_trans_handle;
> struct btrfs_transaction;
> --
> 2.47.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-01 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-30 16:18 [PATCH] btrfs: remove unnecessary forward struct declarations in volumes.h fdmanana
2026-10-01 9:05 ` Qu Wenruo
2026-10-01 11:27 ` Daniel Vacek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox