From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 5/8] btrfs: Increment device corruption error in case of checksum error
Date: Thu, 2 Jul 2020 17:44:02 +0300 [thread overview]
Message-ID: <885366c5-9c8d-a6c9-95d2-89668ea6641a@suse.com> (raw)
In-Reply-To: <SN4PR0401MB3598A71152884496C7A20A289B6D0@SN4PR0401MB3598.namprd04.prod.outlook.com>
On 2.07.20 г. 16:21 ч., Johannes Thumshirn wrote:
> On 02/07/2020 14:41, Nikolay Borisov wrote:
>> Now that btrfs_io_bio have access to btrfs_device we can safely
>> increment the device corruption counter on error. There is one notable
>> exception - repair bios for raid. Since those don't go through the
>> normal submit_stripe_bio callpath but through raid56_parity_recover thus
>> repair bios won't have their device set.
>>
>> Link: https://lore.kernel.org/linux-btrfs/4857863.FCrPRfMyHP@liv/
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>> ---
>> fs/btrfs/inode.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
>> index e7600b0fd9b5..c6824d0ce59d 100644
>> --- a/fs/btrfs/inode.c
>> +++ b/fs/btrfs/inode.c
>> @@ -2822,6 +2822,9 @@ static int check_data_csum(struct inode *inode, struct btrfs_io_bio *io_bio,
>> zeroit:
>> btrfs_print_data_csum_error(BTRFS_I(inode), start, csum, csum_expected,
>> io_bio->mirror_num);
>> + if (io_bio->dev)
>> + btrfs_dev_stat_inc_and_print(io_bio->dev,
>> + BTRFS_DEV_STAT_CORRUPTION_ERRS);
>> memset(kaddr + pgoff, 1, len);
>> flush_dcache_page(page);
>> kunmap_atomic(kaddr);
>
> Any chance you could do a follow up merging that weird zeroit label
> into the memset() block?
>
> It kind of disturbs the reading flow of that function and in fact it
> doesn't even zero the data
>
Makes sense, it doesn't even look that bad at all in terms of line length.
next prev parent reply other threads:[~2020-07-02 14:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 12:23 [PATCH 0/7] Corrupt counter improvement Nikolay Borisov
2020-07-02 12:23 ` [PATCH 1/8] btrfs: Make get_state_failrec return failrec directly Nikolay Borisov
2020-07-02 13:07 ` Josef Bacik
2020-07-02 13:25 ` David Sterba
2020-07-02 12:23 ` [PATCH 2/8] btrfs: Streamline btrfs_get_io_failure_record logic Nikolay Borisov
2020-07-02 13:13 ` Josef Bacik
2020-07-02 12:23 ` [PATCH 3/8] btrfs: Record btrfs_device directly btrfs_io_bio Nikolay Borisov
2020-07-02 13:14 ` Josef Bacik
2020-07-02 13:16 ` Johannes Thumshirn
2020-07-03 8:14 ` [PATCH v2] " Nikolay Borisov
2020-07-03 13:06 ` Johannes Thumshirn
2020-07-02 12:23 ` [PATCH 4/8] btrfs: Don't check for btrfs_device::bdev in btrfs_end_bio Nikolay Borisov
2020-07-02 13:15 ` Josef Bacik
2020-07-02 12:23 ` [PATCH 5/8] btrfs: Increment device corruption error in case of checksum error Nikolay Borisov
2020-07-02 13:18 ` Josef Bacik
2020-07-02 13:21 ` Johannes Thumshirn
2020-07-02 14:44 ` Nikolay Borisov [this message]
2020-07-02 12:23 ` [PATCH 6/8] btrfs: Remove needless ASSERT Nikolay Borisov
2020-07-02 13:19 ` Josef Bacik
2020-07-02 13:26 ` Johannes Thumshirn
2020-07-02 12:23 ` [PATCH 7/8] btrfs: Increment corrupt device counter during compressed read Nikolay Borisov
2020-07-02 13:21 ` Josef Bacik
2020-07-02 13:28 ` Johannes Thumshirn
2020-07-02 12:23 ` [PATCH 8/8] btrfs: sysfs: Add bdi link to the fsid dir Nikolay Borisov
2020-07-02 13:25 ` Josef Bacik
2020-07-02 13:36 ` David Sterba
2020-07-02 14:41 ` Nikolay Borisov
2020-07-03 8:13 ` [PATCH v2] " Nikolay Borisov
2020-07-05 11:39 ` Anand Jain
2020-07-03 15:32 ` [PATCH 0/7] Corrupt counter improvement David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885366c5-9c8d-a6c9-95d2-89668ea6641a@suse.com \
--to=nborisov@suse.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox