From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC 4/7] btrfs: trace, add event btrfs_read_policy
Date: Wed, 28 Oct 2020 16:59:24 +0800 [thread overview]
Message-ID: <9e2c88d0-b13a-d175-38e9-7cd0e802acf8@oracle.com> (raw)
In-Reply-To: <eaf39974-65db-4a38-4342-f7dbea4d06bc@toxicpanda.com>
On 28/10/20 2:22 am, Josef Bacik wrote:
> On 10/26/20 7:55 PM, Anand Jain wrote:
>> This patch adds trace event btrfs_read_policy, which is common to all the
>> read policies.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> fs/btrfs/volumes.c | 28 ++++++++++++++++++++++++++--
>> include/trace/events/btrfs.h | 20 ++++++++++++++++++++
>> 2 files changed, 46 insertions(+), 2 deletions(-)
>
> Noooooo this isn't the way we do this. Simply make a trace class with
> all the variations, and then add individual trace events that inherit
> from the class that print out the appropriate values. Thanks,
>
I added this mainly to debug the inflight thing. I was kind of not so
successful in finding a relation between latency, queue depth, and
inflight. As it is gone now, I doubt if we still need tracing. I am ok
to drop this. Or we could add when we start digging anything around
this?
Thanks, Anand
> Josef
next prev parent reply other threads:[~2020-10-28 21:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 23:55 [PATCH RFC 0/7] btrfs: read_policy types latency, device and Anand Jain
2020-10-26 23:55 ` [PATCH RFC 1/7] block: export part_stat_read_all Anand Jain
2020-10-27 18:09 ` Josef Bacik
2020-10-28 8:26 ` Anand Jain
2020-10-26 23:55 ` [PATCH RFC 2/7] block: export part_stat_read_inflight Anand Jain
2020-10-27 18:10 ` Josef Bacik
2020-10-28 8:32 ` Anand Jain
2020-10-26 23:55 ` [PATCH RFC 3/7] btrfs: add read_policy latency Anand Jain
2020-10-27 18:20 ` Josef Bacik
2020-10-26 23:55 ` [PATCH RFC 4/7] btrfs: trace, add event btrfs_read_policy Anand Jain
2020-10-27 18:22 ` Josef Bacik
2020-10-28 8:59 ` Anand Jain [this message]
2020-10-28 12:41 ` Josef Bacik
2020-10-26 23:55 ` [PATCH 5/7] btrfs: introduce new device-state read_preferred Anand Jain
2020-10-26 23:55 ` [PATCH 6/7] btrfs: introduce new read_policy device Anand Jain
2020-10-27 7:11 ` Wang Yugui
2020-10-26 23:55 ` [PATCH RFC 7/7] btrfs: introduce new read_policy round-robin Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e2c88d0-b13a-d175-38e9-7cd0e802acf8@oracle.com \
--to=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox