From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC 4/7] btrfs: trace, add event btrfs_read_policy
Date: Tue, 27 Oct 2020 14:22:46 -0400 [thread overview]
Message-ID: <eaf39974-65db-4a38-4342-f7dbea4d06bc@toxicpanda.com> (raw)
In-Reply-To: <e6e5c40113cd3e939441ab3ece823282049a596f.1603751876.git.anand.jain@oracle.com>
On 10/26/20 7:55 PM, Anand Jain wrote:
> This patch adds trace event btrfs_read_policy, which is common to all the
> read policies.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/volumes.c | 28 ++++++++++++++++++++++++++--
> include/trace/events/btrfs.h | 20 ++++++++++++++++++++
> 2 files changed, 46 insertions(+), 2 deletions(-)
Noooooo this isn't the way we do this. Simply make a trace class with all the
variations, and then add individual trace events that inherit from the class
that print out the appropriate values. Thanks,
Josef
next prev parent reply other threads:[~2020-10-27 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 23:55 [PATCH RFC 0/7] btrfs: read_policy types latency, device and Anand Jain
2020-10-26 23:55 ` [PATCH RFC 1/7] block: export part_stat_read_all Anand Jain
2020-10-27 18:09 ` Josef Bacik
2020-10-28 8:26 ` Anand Jain
2020-10-26 23:55 ` [PATCH RFC 2/7] block: export part_stat_read_inflight Anand Jain
2020-10-27 18:10 ` Josef Bacik
2020-10-28 8:32 ` Anand Jain
2020-10-26 23:55 ` [PATCH RFC 3/7] btrfs: add read_policy latency Anand Jain
2020-10-27 18:20 ` Josef Bacik
2020-10-26 23:55 ` [PATCH RFC 4/7] btrfs: trace, add event btrfs_read_policy Anand Jain
2020-10-27 18:22 ` Josef Bacik [this message]
2020-10-28 8:59 ` Anand Jain
2020-10-28 12:41 ` Josef Bacik
2020-10-26 23:55 ` [PATCH 5/7] btrfs: introduce new device-state read_preferred Anand Jain
2020-10-26 23:55 ` [PATCH 6/7] btrfs: introduce new read_policy device Anand Jain
2020-10-27 7:11 ` Wang Yugui
2020-10-26 23:55 ` [PATCH RFC 7/7] btrfs: introduce new read_policy round-robin Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf39974-65db-4a38-4342-f7dbea4d06bc@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox