Re: [PATCH] btrfs-progs: Add basic .editorconfig

["Daniel Xu" <dxu@dxuuu.xyz>]

On Mon Jul 27, 2020 at 6:57 PM PDT, Qu Wenruo wrote:
>
>
> On 2020/7/28 上午9:50, Qu Wenruo wrote:
> > 
> > 
> > On 2020/7/28 上午9:24, Daniel Xu wrote:
> >> Not all contributors work on projects that use linux kernel coding
> >> style. This commit adds a basic editorconfig [0] to assist contributors
> >> with managing configuration.
> >>
> >> [0]: https://editorconfig.org/
> > 
> > I like the idea of the generic style file.
> > It's just one single file for all editors.
> > 
> > Although most btrfs developers I know use vim, and it's not supported
> > natively, it shouldn't be a big problem, a plugin would handle it
> > without problem.
> > 
> >>
> >> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> > 
> > Reviewed-by: Qu Wenruo <wqu@suse.com>
> > 
> > But a small nitpick inlined below.
> > 
> >> ---
> >>  .editorconfig | 10 ++++++++++
> >>  .gitignore    |  1 +
> >>  2 files changed, 11 insertions(+)
> >>  create mode 100644 .editorconfig
> >>
> >> diff --git a/.editorconfig b/.editorconfig
> >> new file mode 100644
> >> index 00000000..2829cfbe
> >> --- /dev/null
> >> +++ b/.editorconfig
> >> @@ -0,0 +1,10 @@
> >> +[*]
> >> +end_of_line = lf
> >> +insert_final_newline = true
> >> +trim_trailing_whitespace = true
> >> +charset = utf-8
> >> +indent_style = space
>
> Wait for a minute, does that mean, we use space as indent?
> IIRC kernel code style goes tab if possible?
>
> Thanks,
> Qu

Sorry, that was mistake. Just sent out a V2 before I saw your email.

Thanks,
Daniel