From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] btrfs: avoid double clean up when submit_one_bio() failed
Date: Fri, 15 Apr 2022 00:12:10 -0700 [thread overview]
Message-ID: <YlkayiTPf93aBpSD@infradead.org> (raw)
In-Reply-To: <37226b35-7d5a-dd86-7b20-7a0dfd3b96fc@gmx.com>
On Fri, Apr 15, 2022 at 03:02:41PM +0800, Qu Wenruo wrote:
> But this can not be said to btrfs_submit_compressed_read(), which has
> the same problem and can be triggered by EIO error easily.
>
> Do you want to give it a try? Or mind to me fix it?
I don't really know the btrfs writeback and compression code very well,
so if you can tackle it that would be great. I'll review it and will
ask lots of stupid question in exchange :)
next prev parent reply other threads:[~2022-04-15 7:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 12:30 [PATCH v2 0/3] btrfs: vairous bug fixes related to generic/475 failure with subpage cases Qu Wenruo
2022-04-12 12:30 ` [PATCH v2 1/3] btrfs: avoid double clean up when submit_one_bio() failed Qu Wenruo
2022-04-12 20:41 ` David Sterba
2022-04-12 23:32 ` Qu Wenruo
2022-04-13 13:46 ` David Sterba
2022-04-13 23:23 ` Qu Wenruo
2022-04-15 6:28 ` Christoph Hellwig
2022-04-15 7:02 ` Qu Wenruo
2022-04-15 7:12 ` Christoph Hellwig [this message]
2022-04-15 7:14 ` Qu Wenruo
2022-04-24 23:26 ` Qu Wenruo
2022-04-12 12:30 ` [PATCH v2 2/3] btrfs: fix the error handling for submit_extent_page() for btrfs_do_readpage() Qu Wenruo
2022-04-12 12:30 ` [PATCH v2 3/3] btrfs: return correct error number for __extent_writepage_io() Qu Wenruo
2022-04-12 20:42 ` [PATCH v2 0/3] btrfs: vairous bug fixes related to generic/475 failure with subpage cases David Sterba
2022-04-14 19:38 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlkayiTPf93aBpSD@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=stable@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox