From: Josef Bacik <josef@toxicpanda.com>
To: Ioannis Angelakopoulos <iangelak@fb.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 0/6] btrfs: Annotate wait events with lockdep
Date: Fri, 22 Jul 2022 09:36:29 -0400 [thread overview]
Message-ID: <Ytqn3ROQAGJxkTL3@localhost.localdomain> (raw)
In-Reply-To: <20220720233818.3107724-1-iangelak@fb.com>
On Wed, Jul 20, 2022 at 04:38:13PM -0700, Ioannis Angelakopoulos wrote:
> Hello,
>
> With this patch series we annotate wait events in btrfs with lockdep to
> catch deadlocks involving these wait events.
>
> Recently the btrfs developers fixed a non trivial deadlock involving
> wait events
> https://lore.kernel.org/linux-btrfs/20220614131413.GJ20633@twin.jikos.cz/
>
> Currently lockdep is unable to catch these deadlocks since it does not
> support wait events by default.
>
> With our lockdep annotations we train lockdep to track these wait events
> and catch more potential deadlocks.
>
> Specifically, we annotate the below wait events in fs/btrfs/transaction.c
> and in fs/btrfs/ordered-data.c:
>
> 1) The num_writers wait event
> 2) The num_extwriters wait event
> 3) The transaction states wait events
> 4) The pending_ordered wait event
> 5) The ordered extents wait event
>
You can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
to the series, thanks,
Josef
prev parent reply other threads:[~2022-07-22 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 23:38 [PATCH v3 0/6] btrfs: Annotate wait events with lockdep Ioannis Angelakopoulos
2022-07-20 23:38 ` [PATCH v3 1/6] btrfs: Add a lockdep model for the num_writers wait event Ioannis Angelakopoulos
2022-07-21 0:42 ` Wang Yugui
2022-07-21 16:37 ` Ioannis Angelakopoulos
2022-07-20 23:38 ` [PATCH v3 2/6] btrfs: Add a lockdep model for the num_extwriters " Ioannis Angelakopoulos
2022-07-20 23:38 ` [PATCH v3 3/6] btrfs: Add lockdep models for the transaction states wait events Ioannis Angelakopoulos
2022-07-20 23:38 ` [PATCH v3 4/6] btrfs: Add a lockdep model for the pending_ordered wait event Ioannis Angelakopoulos
2022-07-20 23:38 ` [PATCH v3 5/6] btrfs: Change the lockdep class of struct inode's invalidate_lock Ioannis Angelakopoulos
2022-07-20 23:38 ` [PATCH v3 6/6] btrfs: Add a lockdep model for the ordered extents wait event Ioannis Angelakopoulos
2022-07-22 13:36 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytqn3ROQAGJxkTL3@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=iangelak@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox