From: Christoph Hellwig <hch@infradead.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-btrfs@vger.kernel.org, josef@toxicpanda.com,
dsterba@suse.com, clm@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: make btrfs_compressed_bioset static
Date: Sun, 18 Jun 2023 22:00:53 -0700 [thread overview]
Message-ID: <ZI/hBdEdSvEirz/C@infradead.org> (raw)
In-Reply-To: <20230616172443.87681-1-ben.dooks@codethink.co.uk>
On Fri, Jun 16, 2023 at 06:24:43PM +0100, Ben Dooks wrote:
> The 'btrfs_compressed_bioset' struct isn't exported outside of the
> fs/btrfs/compression.c file, so make it static to fix the following
> sparse warning:
>
> fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?
>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-19 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 17:24 [PATCH] btrfs: make btrfs_compressed_bioset static Ben Dooks
2023-06-19 5:00 ` Christoph Hellwig [this message]
2023-06-19 15:02 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI/hBdEdSvEirz/C@infradead.org \
--to=hch@infradead.org \
--cc=ben.dooks@codethink.co.uk \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox