* [PATCH] btrfs: make btrfs_compressed_bioset static
@ 2023-06-16 17:24 Ben Dooks
2023-06-19 5:00 ` Christoph Hellwig
2023-06-19 15:02 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2023-06-16 17:24 UTC (permalink / raw)
To: linux-btrfs, josef, dsterba, clm; +Cc: linux-kernel, Ben Dooks
The 'btrfs_compressed_bioset' struct isn't exported outside of the
fs/btrfs/compression.c file, so make it static to fix the following
sparse warning:
fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
fs/btrfs/compression.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 2d0493f0a184..10d8b76313dc 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -37,7 +37,7 @@
#include "file-item.h"
#include "super.h"
-struct bio_set btrfs_compressed_bioset;
+static struct bio_set btrfs_compressed_bioset;
static const char* const btrfs_compress_types[] = { "", "zlib", "lzo", "zstd" };
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: make btrfs_compressed_bioset static
2023-06-16 17:24 [PATCH] btrfs: make btrfs_compressed_bioset static Ben Dooks
@ 2023-06-19 5:00 ` Christoph Hellwig
2023-06-19 15:02 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-06-19 5:00 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-btrfs, josef, dsterba, clm, linux-kernel
On Fri, Jun 16, 2023 at 06:24:43PM +0100, Ben Dooks wrote:
> The 'btrfs_compressed_bioset' struct isn't exported outside of the
> fs/btrfs/compression.c file, so make it static to fix the following
> sparse warning:
>
> fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?
>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: make btrfs_compressed_bioset static
2023-06-16 17:24 [PATCH] btrfs: make btrfs_compressed_bioset static Ben Dooks
2023-06-19 5:00 ` Christoph Hellwig
@ 2023-06-19 15:02 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2023-06-19 15:02 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-btrfs, josef, dsterba, clm, linux-kernel
On Fri, Jun 16, 2023 at 06:24:43PM +0100, Ben Dooks wrote:
> The 'btrfs_compressed_bioset' struct isn't exported outside of the
> fs/btrfs/compression.c file, so make it static to fix the following
> sparse warning:
>
> fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-19 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-16 17:24 [PATCH] btrfs: make btrfs_compressed_bioset static Ben Dooks
2023-06-19 5:00 ` Christoph Hellwig
2023-06-19 15:02 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox