From: Michal Hocko <mhocko@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, Vlastimil Babka <vbabka@kernel.org>
Subject: Re: [PATCH v5 1/2] btrfs: always uses root memcgroup for filemap_add_folio()
Date: Fri, 19 Jul 2024 09:26:50 +0200 [thread overview]
Message-ID: <ZpoVOvMe7Tt9Ok49@tiehlicka> (raw)
In-Reply-To: <99334ebf-583a-4295-be52-118c253d5fca@gmx.com>
On Fri 19-07-24 16:46:50, Qu Wenruo wrote:
> Meanwhile, can we just define root_mem_cgroup as NULL globally?
> That looks more reasonable to me, and if that's fine I can send out an
> extra patch just for that.
I think it would be sufficient to pull root_mem_cgroup declaration out
of ifdef in memcontrol.h. We do not really have to define it. Please
send the patch and add all memcg maintainers. Ideally with this patch in
the series so that the intention is clear.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-07-19 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 4:49 [PATCH v5 0/2] btrfs: try to allocate larger folios for metadata Qu Wenruo
2024-07-19 4:49 ` [PATCH v5 1/2] btrfs: always uses root memcgroup for filemap_add_folio() Qu Wenruo
2024-07-19 7:08 ` Michal Hocko
2024-07-19 7:16 ` Qu Wenruo
2024-07-19 7:20 ` Qu Wenruo
2024-07-19 7:26 ` Michal Hocko [this message]
2024-07-19 15:42 ` kernel test robot
2024-07-19 15:42 ` kernel test robot
2024-07-19 4:49 ` [PATCH v5 2/2] btrfs: prefer to allocate larger folio for metadata Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpoVOvMe7Tt9Ok49@tiehlicka \
--to=mhocko@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=vbabka@kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox