From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
Askar Safin <safinaskar@gmail.com>
Subject: Re: [PATCH RFC 2/2] fs: fully sync all fses even for an emergency sync
Date: Mon, 3 Nov 2025 04:04:45 -0800 [thread overview]
Message-ID: <aQiaXVkz1QYkMsWA@infradead.org> (raw)
In-Reply-To: <aQiYZqX5aGn-FW56@infradead.org>
Forgot to add, but I think the main issue here is that btrfs clears the
writeback flag on the folio before commiting the metadata for the
writeback. I tried to fix this a few years ago, and IIRC Josef tried
again a few month ago. If that is fixed, even a non-blocking writeback
will commit all the updates it actually kicked off, just like for other
file systems. (It will also sort out all kinds of annoying locking
issues)
next prev parent reply other threads:[~2025-11-03 12:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 4:07 [PATCH RFC 0/2] fs: fully sync all fsese even for an emergency sync Qu Wenruo
2025-11-03 4:07 ` [PATCH RFC 1/2] fs: do not pass a parameter for sync_inodes_one_sb() Qu Wenruo
2025-11-03 11:51 ` Christoph Hellwig
2025-11-04 8:42 ` Jan Kara
2025-11-05 18:50 ` Daniel Vacek
2025-11-03 4:07 ` [PATCH RFC 2/2] fs: fully sync all fses even for an emergency sync Qu Wenruo
2025-11-03 11:56 ` Christoph Hellwig
2025-11-03 12:04 ` Christoph Hellwig [this message]
2025-11-03 20:46 ` Qu Wenruo
2025-11-03 20:55 ` Qu Wenruo
2025-11-04 8:28 ` Jan Kara
2025-11-04 8:39 ` Jan Kara
2025-11-05 11:32 ` Christian Brauner
2025-11-04 8:43 ` Qu Wenruo
2025-11-04 12:42 ` Jan Kara
2025-11-04 15:48 ` Christoph Hellwig
2025-11-03 16:00 ` [PATCH RFC 0/2] fs: fully sync all fsese " Askar Safin
2025-11-05 11:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQiaXVkz1QYkMsWA@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=safinaskar@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox