From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] btrfs: tree-checker: Refactor root key check into separate function
Date: Mon, 9 Dec 2019 14:12:45 +0200 [thread overview]
Message-ID: <ad764d71-b2a1-8098-4c18-682c0e952935@suse.com> (raw)
In-Reply-To: <20191209105435.36041-3-wqu@suse.com>
On 9.12.19 г. 12:54 ч., Qu Wenruo wrote:
> ROOT_ITEM key check itself is not as simple as single line check, and
> will be reused for both ROOT_ITEM and DIR_ITEM/DIR_INDEX location key
> check, so refactor such check into check_root_key().
>
> Also since we are here, fix a comment error about ROOT_ITEM offset,
> which is transid of snapshot creation, not some "older kernel behavior".
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by : Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2019-12-09 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 10:54 [PATCH 1/4] btrfs: tree-checker: Clean up fs_info parameter from error message wrapper Qu Wenruo
2019-12-09 10:54 ` [PATCH 2/4] btrfs: tree-checker: Refactor inode key check into seperate function Qu Wenruo
2019-12-09 12:11 ` Nikolay Borisov
2019-12-10 14:42 ` Su Yue
2019-12-11 0:24 ` Qu WenRuo
2019-12-09 10:54 ` [PATCH 3/4] btrfs: tree-checker: Refactor root key check into separate function Qu Wenruo
2019-12-09 12:12 ` Nikolay Borisov [this message]
2019-12-09 10:54 ` [PATCH 4/4] btrfs: tree-checker: Verify location key for DIR_ITEM/DIR_INDEX Qu Wenruo
2019-12-09 12:07 ` [PATCH 1/4] btrfs: tree-checker: Clean up fs_info parameter from error message wrapper Nikolay Borisov
2020-01-02 15:04 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad764d71-b2a1-8098-4c18-682c0e952935@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox