* [PATCH] btrfs-progs: add extent-tree-v2 support to dump-super @ 2022-10-08 9:02 Anand Jain 2022-10-08 23:13 ` Qu Wenruo 0 siblings, 1 reply; 4+ messages in thread From: Anand Jain @ 2022-10-08 9:02 UTC (permalink / raw) To: linux-btrfs Signed-off-by: Anand Jain <anand.jain@oracle.com> --- kernel-shared/print-tree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c index 5c3d14298b58..6b5fd37ab2bc 100644 --- a/kernel-shared/print-tree.c +++ b/kernel-shared/print-tree.c @@ -1689,6 +1689,9 @@ static struct readable_flag_entry incompat_flags_array[] = { DEF_INCOMPAT_FLAG_ENTRY(METADATA_UUID), DEF_INCOMPAT_FLAG_ENTRY(RAID1C34), DEF_INCOMPAT_FLAG_ENTRY(ZONED), +#if EXPERIMENTAL + DEF_INCOMPAT_FLAG_ENTRY(EXTENT_TREE_V2), +#endif }; static const int incompat_flags_num = sizeof(incompat_flags_array) / sizeof(struct readable_flag_entry); -- 2.31.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: add extent-tree-v2 support to dump-super 2022-10-08 9:02 [PATCH] btrfs-progs: add extent-tree-v2 support to dump-super Anand Jain @ 2022-10-08 23:13 ` Qu Wenruo 2022-10-10 7:43 ` Anand Jain 0 siblings, 1 reply; 4+ messages in thread From: Qu Wenruo @ 2022-10-08 23:13 UTC (permalink / raw) To: Anand Jain, linux-btrfs On 2022/10/8 17:02, Anand Jain wrote: > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > kernel-shared/print-tree.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c > index 5c3d14298b58..6b5fd37ab2bc 100644 > --- a/kernel-shared/print-tree.c > +++ b/kernel-shared/print-tree.c > @@ -1689,6 +1689,9 @@ static struct readable_flag_entry incompat_flags_array[] = { > DEF_INCOMPAT_FLAG_ENTRY(METADATA_UUID), > DEF_INCOMPAT_FLAG_ENTRY(RAID1C34), > DEF_INCOMPAT_FLAG_ENTRY(ZONED), > +#if EXPERIMENTAL > + DEF_INCOMPAT_FLAG_ENTRY(EXTENT_TREE_V2), > +#endif That's in fact one solution I want to go. But later I found that, we can enhance __print_readable_flag() to iterate the incompat_flags_array[] with extra check on @supported_flags, so we can skip the EXPERIMENTAL macro inside the array. By that, we can reduce the number of EXPERIMENTAL macros, which I believe is already causing burdens for testing. Thanks, Qu > }; > static const int incompat_flags_num = sizeof(incompat_flags_array) / > sizeof(struct readable_flag_entry); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: add extent-tree-v2 support to dump-super 2022-10-08 23:13 ` Qu Wenruo @ 2022-10-10 7:43 ` Anand Jain 2022-10-10 20:19 ` David Sterba 0 siblings, 1 reply; 4+ messages in thread From: Anand Jain @ 2022-10-10 7:43 UTC (permalink / raw) To: Qu Wenruo, Anand Jain, linux-btrfs On 10/9/22 07:13, Qu Wenruo wrote: > > > On 2022/10/8 17:02, Anand Jain wrote: >> Signed-off-by: Anand Jain <anand.jain@oracle.com> >> --- >> kernel-shared/print-tree.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c >> index 5c3d14298b58..6b5fd37ab2bc 100644 >> --- a/kernel-shared/print-tree.c >> +++ b/kernel-shared/print-tree.c >> @@ -1689,6 +1689,9 @@ static struct readable_flag_entry >> incompat_flags_array[] = { >> DEF_INCOMPAT_FLAG_ENTRY(METADATA_UUID), >> DEF_INCOMPAT_FLAG_ENTRY(RAID1C34), >> DEF_INCOMPAT_FLAG_ENTRY(ZONED), >> +#if EXPERIMENTAL >> + DEF_INCOMPAT_FLAG_ENTRY(EXTENT_TREE_V2), >> +#endif > > That's in fact one solution I want to go. > > But later I found that, we can enhance __print_readable_flag() to > iterate the incompat_flags_array[] with extra check on @supported_flags, > so we can skip the EXPERIMENTAL macro inside the array. > > By that, we can reduce the number of EXPERIMENTAL macros, which I > believe is already causing burdens for testing. Yeah, possible. However, it is a cleanup; I wouldn't mix that in the bug fix, here. Thanks, Anand > > Thanks, > Qu >> }; >> static const int incompat_flags_num = sizeof(incompat_flags_array) / >> sizeof(struct readable_flag_entry); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: add extent-tree-v2 support to dump-super 2022-10-10 7:43 ` Anand Jain @ 2022-10-10 20:19 ` David Sterba 0 siblings, 0 replies; 4+ messages in thread From: David Sterba @ 2022-10-10 20:19 UTC (permalink / raw) To: Anand Jain; +Cc: Qu Wenruo, linux-btrfs On Mon, Oct 10, 2022 at 03:43:51PM +0800, Anand Jain wrote: > On 10/9/22 07:13, Qu Wenruo wrote: > > On 2022/10/8 17:02, Anand Jain wrote: > >> Signed-off-by: Anand Jain <anand.jain@oracle.com> > >> --- > >> kernel-shared/print-tree.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/kernel-shared/print-tree.c b/kernel-shared/print-tree.c > >> index 5c3d14298b58..6b5fd37ab2bc 100644 > >> --- a/kernel-shared/print-tree.c > >> +++ b/kernel-shared/print-tree.c > >> @@ -1689,6 +1689,9 @@ static struct readable_flag_entry > >> incompat_flags_array[] = { > >> DEF_INCOMPAT_FLAG_ENTRY(METADATA_UUID), > >> DEF_INCOMPAT_FLAG_ENTRY(RAID1C34), > >> DEF_INCOMPAT_FLAG_ENTRY(ZONED), > >> +#if EXPERIMENTAL > >> + DEF_INCOMPAT_FLAG_ENTRY(EXTENT_TREE_V2), > >> +#endif > > > > That's in fact one solution I want to go. > > > > But later I found that, we can enhance __print_readable_flag() to > > iterate the incompat_flags_array[] with extra check on @supported_flags, > > so we can skip the EXPERIMENTAL macro inside the array. > > > > By that, we can reduce the number of EXPERIMENTAL macros, which I > > believe is already causing burdens for testing. > > Yeah, possible. However, it is a cleanup; I wouldn't mix that in the bug > fix, here. I'll apply your patch as it's a hotfix, what Qu suggests can be done as consolidation later, though I agree that the number of EXPERIMENTAL ifdefs should be kept reasonable. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-10 20:29 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-08 9:02 [PATCH] btrfs-progs: add extent-tree-v2 support to dump-super Anand Jain 2022-10-08 23:13 ` Qu Wenruo 2022-10-10 7:43 ` Anand Jain 2022-10-10 20:19 ` David Sterba
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox