* Re: [PATCH] fstests: vfstest: skip rejected tmpfile creation
2026-07-17 7:07 [PATCH] fstests: vfstest: skip rejected tmpfile creation Qu Wenruo
@ 2026-07-17 20:19 ` Boris Burkov
2026-07-19 7:20 ` Zorro Lang
2026-07-20 8:10 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Boris Burkov @ 2026-07-17 20:19 UTC (permalink / raw)
To: Qu Wenruo; +Cc: fstests, linux-btrfs
On Fri, Jul 17, 2026 at 04:37:17PM +0930, Qu Wenruo wrote:
> Since kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation with an
> unmapped fsuid or fsgid"), tmpfile creation can be rejected with
> EOVERFLOW, so also skip that error number to avoid false alerts like the
> following:
>
> FSTYP -- ext4
> PLATFORM -- Linux/x86_64 btrfs-vm 7.2.0-rc3-custom+ #411 SMP PREEMPT_DYNAMIC Fri Jul 17 16:24:34 ACST 2026
> MKFS_OPTIONS -- -F /dev/mapper/test-scratch1
> MOUNT_OPTIONS -- -o acl,user_xattr /dev/mapper/test-scratch1 /mnt/scratch
>
> generic/633 1s ... - output mismatch (see /home/adam/xfstests/results//generic/633.out.bad)
> --- tests/generic/633.out 2022-05-11 11:25:30.816666664 +0930
> +++ /home/adam/xfstests/results//generic/633.out.bad 2026-07-17 16:25:45.033967541 +0930
> @@ -1,2 +1,4 @@
> QA output created by 633
> Silence is golden
> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
> ...
> (Run 'diff -u /home/adam/xfstests/tests/generic/633.out /home/adam/xfstests/results//generic/633.out.bad' to see the entire diff)
> Ran: generic/633
> Failures: generic/633
> Failed 1 of 1 tests
>
Reviewed-by: Boris Burkov <boris@bur.io>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> src/vfs/utils.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/vfs/utils.c b/src/vfs/utils.c
> index 0b435afe..d2922cc3 100644
> --- a/src/vfs/utils.c
> +++ b/src/vfs/utils.c
> @@ -941,7 +941,11 @@ bool openat_tmpfile_supported(int dirfd)
>
> fd = openat(dirfd, ".", O_TMPFILE | O_RDWR, S_IXGRP | S_ISGID);
> if (fd == -1) {
> - if (errno == ENOTSUP) {
> + /*
> + * Kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation
> + * with an unmapped fsuid or fsgid") will reject such operation.
> + */
> + if (errno == ENOTSUP || errno == EOVERFLOW) {
> errno = 0; /* Don't report misleading errno. */
> return false;
> } else {
> --
> 2.51.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fstests: vfstest: skip rejected tmpfile creation
2026-07-17 7:07 [PATCH] fstests: vfstest: skip rejected tmpfile creation Qu Wenruo
2026-07-17 20:19 ` Boris Burkov
@ 2026-07-19 7:20 ` Zorro Lang
2026-07-20 8:10 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Zorro Lang @ 2026-07-19 7:20 UTC (permalink / raw)
To: Qu Wenruo; +Cc: fstests, linux-btrfs
On Fri, Jul 17, 2026 at 04:37:17PM +0930, Qu Wenruo wrote:
> Since kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation with an
> unmapped fsuid or fsgid"), tmpfile creation can be rejected with
> EOVERFLOW, so also skip that error number to avoid false alerts like the
> following:
>
> FSTYP -- ext4
> PLATFORM -- Linux/x86_64 btrfs-vm 7.2.0-rc3-custom+ #411 SMP PREEMPT_DYNAMIC Fri Jul 17 16:24:34 ACST 2026
> MKFS_OPTIONS -- -F /dev/mapper/test-scratch1
> MOUNT_OPTIONS -- -o acl,user_xattr /dev/mapper/test-scratch1 /mnt/scratch
>
> generic/633 1s ... - output mismatch (see /home/adam/xfstests/results//generic/633.out.bad)
> --- tests/generic/633.out 2022-05-11 11:25:30.816666664 +0930
> +++ /home/adam/xfstests/results//generic/633.out.bad 2026-07-17 16:25:45.033967541 +0930
> @@ -1,2 +1,4 @@
> QA output created by 633
> Silence is golden
> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
> ...
> (Run 'diff -u /home/adam/xfstests/tests/generic/633.out /home/adam/xfstests/results//generic/633.out.bad' to see the entire diff)
> Ran: generic/633
> Failures: generic/633
> Failed 1 of 1 tests
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> src/vfs/utils.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/vfs/utils.c b/src/vfs/utils.c
> index 0b435afe..d2922cc3 100644
> --- a/src/vfs/utils.c
> +++ b/src/vfs/utils.c
> @@ -941,7 +941,11 @@ bool openat_tmpfile_supported(int dirfd)
>
> fd = openat(dirfd, ".", O_TMPFILE | O_RDWR, S_IXGRP | S_ISGID);
> if (fd == -1) {
> - if (errno == ENOTSUP) {
> + /*
> + * Kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation
> + * with an unmapped fsuid or fsgid") will reject such operation.
> + */
> + if (errno == ENOTSUP || errno == EOVERFLOW) {
Makes sense to me,
Reviewed-by: Zorro Lang <zlang@kernel.org>
> errno = 0; /* Don't report misleading errno. */
> return false;
> } else {
> --
> 2.51.2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fstests: vfstest: skip rejected tmpfile creation
2026-07-17 7:07 [PATCH] fstests: vfstest: skip rejected tmpfile creation Qu Wenruo
2026-07-17 20:19 ` Boris Burkov
2026-07-19 7:20 ` Zorro Lang
@ 2026-07-20 8:10 ` Christoph Hellwig
2026-07-20 8:42 ` Qu Wenruo
2 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2026-07-20 8:10 UTC (permalink / raw)
To: Qu Wenruo
Cc: fstests, linux-btrfs, Christian Brauner, Miklos Szeredi,
Amir Goldstein, linux-unionfs, linux-fsdevel
Christian indicated the fixes for this are in the (somewhat confusingly
titled) "[PATCH 0/2] Support overlayfs in the idmapped mount tests"
series.
It would be good to get a proper review for this as it's beyond my
pay grade.
On Fri, Jul 17, 2026 at 04:37:17PM +0930, Qu Wenruo wrote:
> Since kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation with an
> unmapped fsuid or fsgid"), tmpfile creation can be rejected with
> EOVERFLOW, so also skip that error number to avoid false alerts like the
> following:
>
> FSTYP -- ext4
> PLATFORM -- Linux/x86_64 btrfs-vm 7.2.0-rc3-custom+ #411 SMP PREEMPT_DYNAMIC Fri Jul 17 16:24:34 ACST 2026
> MKFS_OPTIONS -- -F /dev/mapper/test-scratch1
> MOUNT_OPTIONS -- -o acl,user_xattr /dev/mapper/test-scratch1 /mnt/scratch
>
> generic/633 1s ... - output mismatch (see /home/adam/xfstests/results//generic/633.out.bad)
> --- tests/generic/633.out 2022-05-11 11:25:30.816666664 +0930
> +++ /home/adam/xfstests/results//generic/633.out.bad 2026-07-17 16:25:45.033967541 +0930
> @@ -1,2 +1,4 @@
> QA output created by 633
> Silence is golden
> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
> ...
> (Run 'diff -u /home/adam/xfstests/tests/generic/633.out /home/adam/xfstests/results//generic/633.out.bad' to see the entire diff)
> Ran: generic/633
> Failures: generic/633
> Failed 1 of 1 tests
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> src/vfs/utils.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/vfs/utils.c b/src/vfs/utils.c
> index 0b435afe..d2922cc3 100644
> --- a/src/vfs/utils.c
> +++ b/src/vfs/utils.c
> @@ -941,7 +941,11 @@ bool openat_tmpfile_supported(int dirfd)
>
> fd = openat(dirfd, ".", O_TMPFILE | O_RDWR, S_IXGRP | S_ISGID);
> if (fd == -1) {
> - if (errno == ENOTSUP) {
> + /*
> + * Kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation
> + * with an unmapped fsuid or fsgid") will reject such operation.
> + */
> + if (errno == ENOTSUP || errno == EOVERFLOW) {
> errno = 0; /* Don't report misleading errno. */
> return false;
> } else {
> --
> 2.51.2
>
>
---end quoted text---
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fstests: vfstest: skip rejected tmpfile creation
2026-07-20 8:10 ` Christoph Hellwig
@ 2026-07-20 8:42 ` Qu Wenruo
0 siblings, 0 replies; 5+ messages in thread
From: Qu Wenruo @ 2026-07-20 8:42 UTC (permalink / raw)
To: Christoph Hellwig, Qu Wenruo
Cc: fstests, linux-btrfs, Christian Brauner, Miklos Szeredi,
Amir Goldstein, linux-unionfs, linux-fsdevel
在 2026/7/20 17:40, Christoph Hellwig 写道:
> Christian indicated the fixes for this are in the (somewhat confusingly
> titled) "[PATCH 0/2] Support overlayfs in the idmapped mount tests"
> series.
>
> It would be good to get a proper review for this as it's beyond my
> pay grade.
Thanks a lot for pointing that series out.
That series hit me but the name didn't ring my bell initially.
But the commit message of the first patch makes more sense now, and
please drop this patch.
This one is really masking the problem, meanwhile that first patch of
that series is fixing it in a better way.
Please drop this patch.
Thanks,
Qu
>
> On Fri, Jul 17, 2026 at 04:37:17PM +0930, Qu Wenruo wrote:
>> Since kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation with an
>> unmapped fsuid or fsgid"), tmpfile creation can be rejected with
>> EOVERFLOW, so also skip that error number to avoid false alerts like the
>> following:
>>
>> FSTYP -- ext4
>> PLATFORM -- Linux/x86_64 btrfs-vm 7.2.0-rc3-custom+ #411 SMP PREEMPT_DYNAMIC Fri Jul 17 16:24:34 ACST 2026
>> MKFS_OPTIONS -- -F /dev/mapper/test-scratch1
>> MOUNT_OPTIONS -- -o acl,user_xattr /dev/mapper/test-scratch1 /mnt/scratch
>>
>> generic/633 1s ... - output mismatch (see /home/adam/xfstests/results//generic/633.out.bad)
>> --- tests/generic/633.out 2022-05-11 11:25:30.816666664 +0930
>> +++ /home/adam/xfstests/results//generic/633.out.bad 2026-07-17 16:25:45.033967541 +0930
>> @@ -1,2 +1,4 @@
>> QA output created by 633
>> Silence is golden
>> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
>> +utils.c: 948: openat_tmpfile_supported - Value too large for defined data type - failure: create
>> ...
>> (Run 'diff -u /home/adam/xfstests/tests/generic/633.out /home/adam/xfstests/results//generic/633.out.bad' to see the entire diff)
>> Ran: generic/633
>> Failures: generic/633
>> Failed 1 of 1 tests
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>> ---
>> src/vfs/utils.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/vfs/utils.c b/src/vfs/utils.c
>> index 0b435afe..d2922cc3 100644
>> --- a/src/vfs/utils.c
>> +++ b/src/vfs/utils.c
>> @@ -941,7 +941,11 @@ bool openat_tmpfile_supported(int dirfd)
>>
>> fd = openat(dirfd, ".", O_TMPFILE | O_RDWR, S_IXGRP | S_ISGID);
>> if (fd == -1) {
>> - if (errno == ENOTSUP) {
>> + /*
>> + * Kernel commit 539dce114465 ("fs: refuse O_TMPFILE creation
>> + * with an unmapped fsuid or fsgid") will reject such operation.
>> + */
>> + if (errno == ENOTSUP || errno == EOVERFLOW) {
>> errno = 0; /* Don't report misleading errno. */
>> return false;
>> } else {
>> --
>> 2.51.2
>>
>>
> ---end quoted text---
>
^ permalink raw reply [flat|nested] 5+ messages in thread