Re: [PATCH 3/7] btrfs: record delayed inode root in transaction

[Qu Wenruo <wqu@suse.com>]

在 2024/3/27 08:09, Boris Burkov 写道:
> When running delayed inode updates, we do not record the inode's root in
> the transaction, but we do allocate PREALLOC and thus converted PERTRANS
> space for it. To be sure we free that PERTRANS meta rsv, we must ensure
> that we record the root in the transaction.
> 
> Fixes: 4f5427ccce5d ("btrfs: delayed-inode: Use new qgroup meta rsv for delayed inode and item")

Reviewed-by: Qu Wenruo <wqu@suse.com>

Just curious, do you have a case that hits this particular bug only?

Thanks,
Qu
> Signed-off-by: Boris Burkov <boris@bur.io>
> ---
>   fs/btrfs/delayed-inode.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> index dd6f566a383f..121ab890bd05 100644
> --- a/fs/btrfs/delayed-inode.c
> +++ b/fs/btrfs/delayed-inode.c
> @@ -1133,6 +1133,9 @@ __btrfs_commit_inode_delayed_items(struct btrfs_trans_handle *trans,
>   	if (ret)
>   		return ret;
>   
> +	ret = btrfs_record_root_in_trans(trans, node->root);
> +	if (ret)
> +		return ret;
>   	ret = btrfs_update_delayed_inode(trans, node->root, path, node);
>   	return ret;
>   }