From: Boris Burkov <boris@bur.io>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/7] btrfs: various qg meta rsv leak fixes
Date: Tue, 26 Mar 2024 14:39:34 -0700 [thread overview]
Message-ID: <cover.1711488980.git.boris@bur.io> (raw)
generic/269 and generic/475 expose a number of reservation accounting
issues in the btrfs quotas code that is shared between qgroups and
squotas. In particular, error paths for failed transactions and errors
in start_transaction and other critical functions for root per-trans
accounting.
These semi-related patches fix up a number of such issues. With them,
generic/269 with -O squota passed 1000+ times in a row for me and
generic/475 has run hundreds of iterations without ever failing on a
metadata reservation leak warning. generic/475 does still see issues
with qgroup data reservation accounting and only passes ~9/10 times
on my system.
Boris Burkov (7):
btrfs: correctly model root qgroup rsv in convert
btrfs: fix qgroup prealloc rsv leak in subvolume operations
btrfs: record delayed inode root in transaction
btrfs: convert PREALLOC to PERTRANS after record_root_in_trans
btrfs: free pertrans at end of cleanup_transaction
btrfs: btrfs_clear_delalloc_extent frees rsv
btrfs: always clear meta pertrans during commit
fs/btrfs/delayed-inode.c | 3 +++
fs/btrfs/disk-io.c | 3 +--
fs/btrfs/inode.c | 15 +++++++++++++--
fs/btrfs/ioctl.c | 37 ++++++++++++++++++++++++++++---------
fs/btrfs/qgroup.c | 2 ++
fs/btrfs/root-tree.c | 10 ----------
fs/btrfs/root-tree.h | 2 --
fs/btrfs/transaction.c | 19 +++++++++----------
8 files changed, 56 insertions(+), 35 deletions(-)
--
2.44.0
next reply other threads:[~2024-03-26 21:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 21:39 Boris Burkov [this message]
2024-03-26 21:39 ` [PATCH 1/7] btrfs: correctly model root qgroup rsv in convert Boris Burkov
2024-03-26 22:00 ` Qu Wenruo
2024-03-27 17:20 ` Boris Burkov
2024-03-27 19:35 ` Qu Wenruo
2024-03-26 21:39 ` [PATCH 2/7] btrfs: fix qgroup prealloc rsv leak in subvolume operations Boris Burkov
2024-03-26 22:07 ` Qu Wenruo
2024-03-26 21:39 ` [PATCH 3/7] btrfs: record delayed inode root in transaction Boris Burkov
2024-03-26 22:08 ` Qu Wenruo
2024-03-27 17:21 ` Boris Burkov
2024-03-26 21:39 ` [PATCH 4/7] btrfs: convert PREALLOC to PERTRANS after record_root_in_trans Boris Burkov
2024-03-26 22:12 ` Qu Wenruo
2024-03-26 21:39 ` [PATCH 5/7] btrfs: free pertrans at end of cleanup_transaction Boris Burkov
2024-03-26 22:16 ` Qu Wenruo
2024-03-27 17:22 ` Boris Burkov
2024-03-27 19:51 ` Qu Wenruo
2024-03-26 21:39 ` [PATCH 6/7] btrfs: btrfs_clear_delalloc_extent frees rsv Boris Burkov
2024-03-26 22:26 ` Qu Wenruo
2024-03-27 17:26 ` Boris Burkov
2024-03-27 19:39 ` Qu Wenruo
2024-03-26 21:39 ` [PATCH 7/7] btrfs: always clear meta pertrans during commit Boris Burkov
2024-03-26 22:20 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1711488980.git.boris@bur.io \
--to=boris@bur.io \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox