From: Goffredo Baroncelli <kreijack@inwind.it>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: David Sterba <dsterba@suse.cz>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: btrfs-progs: RAID1C3/C4 missing some info in btrfs_raid_array
Date: Wed, 25 Mar 2020 19:57:13 +0100 [thread overview]
Message-ID: <b8b874d0-a60e-2a4c-f3eb-e54539bddc8d@inwind.it> (raw)
In-Reply-To: <cf046899-7a7b-a93b-2340-c996cbfbc6ac@gmx.com>
Hi Qu,
On 3/25/20 1:12 AM, Qu Wenruo wrote:
>
>
> On 2020/3/25 上午4:00, Goffredo Baroncelli wrote:
>> Hi David,
>>
>> I noticed that in btrfs-progs - volumes.c in the array
>> "btrfs_raid_array", the info
>> raid_name and bg_flag are missing for the item BTRFS_RAID_RAID1C3 and
>> BTRFS_RAID_RAID1C4.
>
> In devel branch, it's between RAID_DUP and RAID_1.
Sorry I cant find it. In the devel branch (last commit be952386cab3973b3e15434495d0070d5479516f) I found
$ cat volumes.c
[...]
[BTRFS_RAID_RAID1] = {
.sub_stripes = 1,
.dev_stripes = 1,
.devs_max = 2,
.devs_min = 2,
.tolerated_failures = 1,
.devs_increment = 2,
.ncopies = 2,
.nparity = 0,
.raid_name = "raid1",
.bg_flag = BTRFS_BLOCK_GROUP_RAID1,
.mindev_error = BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET,
},
[BTRFS_RAID_RAID1C3] = {
.sub_stripes = 1,
.dev_stripes = 1,
.devs_max = 3,
.devs_min = 3,
.tolerated_failures = 2,
.devs_increment = 3,
.ncopies = 3,
},
[BTRFS_RAID_RAID1C4] = {
.sub_stripes = 1,
.dev_stripes = 1,
.devs_max = 4,
.devs_min = 4,
.tolerated_failures = 3,
.devs_increment = 4,
.ncopies = 4,
},
[BTRFS_RAID_DUP] = {
[...]
As you can see the items BTRFS_RAID_RAID1C3 and BTRFS_RAID_RAID1C4, missed of the fields '.raid_name' and '.bg_flag';
if you look at BTRFS_RAID_RAID1 item, it has both the fields filled with "raid1" and "BTRFS_BLOCK_GROUP_RAID1".
Am I missing something ?
I am asking that because I need these fields. I don't have problem to issue a patch about that, however I want to be
sure that these fields are not missing for a some valid reason.
BR
G.Baroncelli
>
> Thanks,
> Qu
>>
>> Is it wanted ? Which is the reason to do that ?
>>
>> BR
>> G.Baroncelli
>
--
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2020-03-25 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 20:00 btrfs-progs: RAID1C3/C4 missing some info in btrfs_raid_array Goffredo Baroncelli
2020-03-25 0:12 ` Qu Wenruo
2020-03-25 18:57 ` Goffredo Baroncelli [this message]
2020-03-26 1:09 ` Qu Wenruo
2020-03-26 17:36 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b874d0-a60e-2a4c-f3eb-e54539bddc8d@inwind.it \
--to=kreijack@inwind.it \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox