Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/6] btrfs: remove btrfs_map_block
Date: Wed, 31 May 2023 16:48:07 +0800	[thread overview]
Message-ID: <bb7899ed-b2b6-b7f8-dd40-50094a1bee09@gmx.com> (raw)
In-Reply-To: <20230531041740.375963-4-hch@lst.de>



On 2023/5/31 12:17, Christoph Hellwig wrote:
> There are no users of btrfs_map_block left, so remove it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   fs/btrfs/volumes.c | 8 --------
>   fs/btrfs/volumes.h | 3 ---
>   2 files changed, 11 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index c236bfba0cec3b..4c6405c4ce041d 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -6481,14 +6481,6 @@ int __btrfs_map_block(struct btrfs_fs_info *fs_info, enum btrfs_map_op op,
>   	return ret;
>   }
>
> -int btrfs_map_block(struct btrfs_fs_info *fs_info, enum btrfs_map_op op,
> -		      u64 logical, u64 *length,
> -		      struct btrfs_io_context **bioc_ret, int mirror_num)
> -{
> -	return __btrfs_map_block(fs_info, op, logical, length, bioc_ret,
> -				 NULL, &mirror_num, 0);
> -}
> -
>   /* For Scrub/replace */
>   int btrfs_map_sblock(struct btrfs_fs_info *fs_info, enum btrfs_map_op op,
>   		     u64 logical, u64 *length,
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index e960a51abf873d..481f3ace988c44 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -582,9 +582,6 @@ static inline unsigned long btrfs_chunk_item_size(int num_stripes)
>
>   void btrfs_get_bioc(struct btrfs_io_context *bioc);
>   void btrfs_put_bioc(struct btrfs_io_context *bioc);
> -int btrfs_map_block(struct btrfs_fs_info *fs_info, enum btrfs_map_op op,
> -		    u64 logical, u64 *length,
> -		    struct btrfs_io_context **bioc_ret, int mirror_num);
>   int btrfs_map_sblock(struct btrfs_fs_info *fs_info, enum btrfs_map_op op,
>   		     u64 logical, u64 *length,
>   		     struct btrfs_io_context **bioc_ret);

  reply	other threads:[~2023-05-31  8:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31  4:17 cleanup the btrfs_map_block interface Christoph Hellwig
2023-05-31  4:17 ` [PATCH 1/6] btrfs: remove BTRFS_MAP_DISCARD Christoph Hellwig
2023-05-31  8:45   ` Qu Wenruo
2023-05-31  4:17 ` [PATCH 2/6] btrfs: optimize simple reads in btrfsic_map_block Christoph Hellwig
2023-05-31  8:47   ` Qu Wenruo
2023-05-31 12:31     ` Johannes Thumshirn
2023-05-31 12:35       ` Christoph Hellwig
2023-05-31 12:46         ` Johannes Thumshirn
2023-05-31  4:17 ` [PATCH 3/6] btrfs: remove btrfs_map_block Christoph Hellwig
2023-05-31  8:48   ` Qu Wenruo [this message]
2023-05-31  4:17 ` [PATCH 4/6] btrfs: rename __btrfs_map_block to btrfs_map_block Christoph Hellwig
2023-05-31  8:48   ` Qu Wenruo
2023-05-31  4:17 ` [PATCH 5/6] btrfs: remove btrfs_map_sblock Christoph Hellwig
2023-05-31  8:49   ` Qu Wenruo
2023-05-31  4:17 ` [PATCH 6/6] btrfs: remove need_full_stripe Christoph Hellwig
2023-05-31  8:52   ` Qu Wenruo
2023-05-31 12:37     ` Christoph Hellwig
2023-05-31 12:35 ` cleanup the btrfs_map_block interface Johannes Thumshirn
2023-05-31 23:38 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb7899ed-b2b6-b7f8-dd40-50094a1bee09@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox