From: Nikolay Borisov <nborisov@suse.com>
To: slash@ac.auone-net.jp
Cc: Eryu Guan <guaneryu@gmail.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: fstests: Don't use gawk's strtonum breaking existing fstests
Date: Wed, 11 Dec 2019 18:33:44 +0200 [thread overview]
Message-ID: <c0dd0b84-776c-a089-0769-913879d9aa9c@suse.com> (raw)
In-Reply-To: <cc85789a-6143-e4cc-aa12-6c842ef88016@suse.com>
On 11.12.19 г. 17:53 ч., Nikolay Borisov wrote:
> Hello,
>
> Following upstream commit:
> https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=37520a314bd472ed720ed0611c6b69e418be9b61
>
> breaks btrfs/095 and btrfs/098 tests.
>
The problem is that the old code was using gawk's strtonum and returning
a base 10 number from an octal input. Whereas the existing code gets an
octal number which is again parsed as an octal when using printf. So the
path in question needs to either by reverted or extended so that the
necessary conversion from octal to base 10 is performed _before_ calling
printf.
next prev parent reply other threads:[~2019-12-11 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:53 fstests: Don't use gawk's strtonum breaking existing fstests Nikolay Borisov
2019-12-11 16:33 ` Nikolay Borisov [this message]
2019-12-12 5:16 ` Qu Wenruo
2019-12-12 9:31 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0dd0b84-776c-a089-0769-913879d9aa9c@suse.com \
--to=nborisov@suse.com \
--cc=guaneryu@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=slash@ac.auone-net.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox