* [PATCH] fstests: generic/537: remove the btrfs specific mount option
@ 2025-05-19 5:28 Qu Wenruo
2025-05-20 12:29 ` David Sterba
2025-05-24 7:31 ` Anand Jain
0 siblings, 2 replies; 3+ messages in thread
From: Qu Wenruo @ 2025-05-19 5:28 UTC (permalink / raw)
To: linux-btrfs, fstests
Although btrfs deprecated "norecovery" mount option in upstream kernel
commit a1912f712188 ("btrfs: remove code for inode_cache and recovery
mount options"), later "norecovery" mount option is re-introduced for
compatibility by commit 440861b1a03c ("btrfs: re-introduce 'norecovery'
mount option").
Instead the btrfs specific mount option "nologreplay" is already
deprecated for a long time and is going to be removed soon.
So use the generic "norecovery" for all filesystems.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/generic/537 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/generic/537 b/tests/generic/537
index 3be743c4..77d38bbf 100755
--- a/tests/generic/537
+++ b/tests/generic/537
@@ -55,7 +55,6 @@ fi
echo "fstrim on ro mount with no log replay"
norecovery="norecovery"
-test $FSTYP = "btrfs" && norecovery=nologreplay
_scratch_mount -o ro,$norecovery >> $seqres.full 2>&1
$FSTRIM_PROG -v $SCRATCH_MNT >> $seqres.full 2>&1 && \
echo "fstrim with unrecovered metadata just ate your filesystem"
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fstests: generic/537: remove the btrfs specific mount option
2025-05-19 5:28 [PATCH] fstests: generic/537: remove the btrfs specific mount option Qu Wenruo
@ 2025-05-20 12:29 ` David Sterba
2025-05-24 7:31 ` Anand Jain
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2025-05-20 12:29 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs, fstests
On Mon, May 19, 2025 at 02:58:39PM +0930, Qu Wenruo wrote:
> Although btrfs deprecated "norecovery" mount option in upstream kernel
> commit a1912f712188 ("btrfs: remove code for inode_cache and recovery
> mount options"), later "norecovery" mount option is re-introduced for
> compatibility by commit 440861b1a03c ("btrfs: re-introduce 'norecovery'
> mount option").
>
> Instead the btrfs specific mount option "nologreplay" is already
> deprecated for a long time and is going to be removed soon.
>
> So use the generic "norecovery" for all filesystems.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fstests: generic/537: remove the btrfs specific mount option
2025-05-19 5:28 [PATCH] fstests: generic/537: remove the btrfs specific mount option Qu Wenruo
2025-05-20 12:29 ` David Sterba
@ 2025-05-24 7:31 ` Anand Jain
1 sibling, 0 replies; 3+ messages in thread
From: Anand Jain @ 2025-05-24 7:31 UTC (permalink / raw)
To: Qu Wenruo, linux-btrfs, fstests
looks good.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-24 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-19 5:28 [PATCH] fstests: generic/537: remove the btrfs specific mount option Qu Wenruo
2025-05-20 12:29 ` David Sterba
2025-05-24 7:31 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox