Re: [PATCH 0/5] btrfs: prepare for larger folios support

[Johannes Thumshirn <Johannes.Thumshirn@wdc.com>]

On 20.02.25 10:26, Qu Wenruo wrote:
> Qu Wenruo (5):
>    btrfs: prepare subpage.c for larger folios support
>    btrfs: remove the PAGE_SIZE usage inside inline extent reads
>    btrfs: prepare btrfs_launcher_folio() for larger folios support
>    btrfs: prepare extent_io.c for future larger folio support
>    btrfs: prepare btrfs_page_mkwrite() for larger folios
> 
>   fs/btrfs/extent_io.c | 50 +++++++++++++++++++++++++-------------------
>   fs/btrfs/file.c      | 19 +++++++++--------
>   fs/btrfs/inode.c     |  8 +++----
>   fs/btrfs/subpage.c   | 36 +++++++++++++++----------------
>   fs/btrfs/subpage.h   | 24 ++++++++-------------
>   5 files changed, 69 insertions(+), 68 deletions(-)
> 

Hi Qu,
What am I doing wrong?

Applying: btrfs: prepare subpage.c for larger folios support
Applying: btrfs: remove the PAGE_SIZE usage inside inline extent reads
In file included from ./include/linux/kernel.h:28,
                  from ./include/linux/cpumask.h:11,
                  from ./include/linux/smp.h:13,
                  from ./include/linux/lockdep.h:14,
                  from ./include/linux/spinlock.h:63,
                  from ./include/linux/swait.h:7,
                  from ./include/linux/completion.h:12,
                  from ./include/linux/crypto.h:15,
                  from ./include/crypto/hash.h:12,
                  from fs/btrfs/inode.c:6:
fs/btrfs/inode.c: In function ‘uncompress_inline’:
fs/btrfs/inode.c:6807:41: error: ‘sectorsize’ undeclared (first use in 
this function); did you mean ‘sector_t’?
  6807 |         max_size = min_t(unsigned long, sectorsize, max_size);
       |                                         ^~~~~~~~~~
./include/linux/minmax.h:86:23: note: in definition of macro 
‘__cmp_once_unique’
    86 |         ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
       |                       ^
./include/linux/minmax.h:161:27: note: in expansion of macro ‘__cmp_once’
   161 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
       |                           ^~~~~~~~~~
fs/btrfs/inode.c:6807:20: note: in expansion of macro ‘min_t’
  6807 |         max_size = min_t(unsigned long, sectorsize, max_size);
       |                    ^~~~~
fs/btrfs/inode.c:6807:41: note: each undeclared identifier is reported 
only once for each function it appears in
  6807 |         max_size = min_t(unsigned long, sectorsize, max_size);
       |                                         ^~~~~~~~~~
./include/linux/minmax.h:86:23: note: in definition of macro 
‘__cmp_once_unique’
    86 |         ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
       |                       ^
./include/linux/minmax.h:161:27: note: in expansion of macro ‘__cmp_once’
   161 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
       |                           ^~~~~~~~~~
fs/btrfs/inode.c:6807:20: note: in expansion of macro ‘min_t’
  6807 |         max_size = min_t(unsigned long, sectorsize, max_size);
       |                    ^~~~~
fs/btrfs/inode.c: In function ‘read_inline_extent’:
fs/btrfs/inode.c:6841:32: error: ‘sectorsize’ undeclared (first use in 
this function); did you mean ‘sector_t’?
  6841 |         copy_size = min_t(u64, sectorsize,
       |                                ^~~~~~~~~~
./include/linux/minmax.h:86:23: note: in definition of macro 
‘__cmp_once_unique’
    86 |         ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
       |                       ^
./include/linux/minmax.h:161:27: note: in expansion of macro ‘__cmp_once’
   161 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
       |                           ^~~~~~~~~~
fs/btrfs/inode.c:6841:21: note: in expansion of macro ‘min_t’
  6841 |         copy_size = min_t(u64, sectorsize,
       |                     ^~~~~
make[4]: *** [scripts/Makefile.build:207: fs/btrfs/inode.o] Error 1
make[3]: *** [scripts/Makefile.build:465: fs/btrfs] Error 2
make[2]: *** [scripts/Makefile.build:465: fs] Error 2
make[1]: *** [/home/johannes/src/linux/Makefile:1989: .] Error 2