From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
WenRuo Qu <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/5] btrfs: prepare subpage.c for larger folios support
Date: Sat, 22 Feb 2025 15:33:05 +1030 [thread overview]
Message-ID: <decd6725-230b-4723-8919-9d5959f5ada0@gmx.com> (raw)
In-Reply-To: <152ee58c-0ebe-4e58-a0a1-94e8c9c51d6d@wdc.com>
在 2025/2/21 22:36, Johannes Thumshirn 写道:
> On 20.02.25 10:24, Qu Wenruo wrote:
>> For the future of larger folio support, even if block size == page size,
>> we may still hit a larger folio and need to attach a subpage structure to
>> that larger folio.
>>
>> In that case we can no longer assume we need to go subpage routine only
>> when block size < page size, but take folio size into the consideration.
>>
>> Prepare for such future by:
>>
>> - Use folio_size() instead of PAGE_SIZE
>> - Make btrfs_alloc_subpage() to handle different folio sizes
>> - Make btrfs_is_subpage() to do the check based on the folio
>
> I personally would split this patch in 3 doing the above. Or at least
> split out the brtfs_is_subpage() part in another patch.
>
Sure, and the next update will only be sent after all the dependency got
merged into for-next branch.
Thanks,
Qu
next prev parent reply other threads:[~2025-02-22 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:22 [PATCH 0/5] btrfs: prepare for larger folios support Qu Wenruo
2025-02-20 9:22 ` [PATCH 1/5] btrfs: prepare subpage.c " Qu Wenruo
2025-02-21 12:06 ` Johannes Thumshirn
2025-02-22 5:03 ` Qu Wenruo [this message]
2025-02-20 9:22 ` [PATCH 2/5] btrfs: remove the PAGE_SIZE usage inside inline extent reads Qu Wenruo
2025-02-21 11:37 ` Johannes Thumshirn
2025-02-20 9:22 ` [PATCH 3/5] btrfs: prepare btrfs_launcher_folio() for larger folios support Qu Wenruo
2025-02-21 12:08 ` Johannes Thumshirn
2025-02-20 9:22 ` [PATCH 4/5] btrfs: prepare extent_io.c for future larger folio support Qu Wenruo
2025-02-21 12:12 ` Johannes Thumshirn
2025-02-22 5:02 ` Qu Wenruo
2025-02-25 18:41 ` Nathan Chancellor
2025-02-20 9:22 ` [PATCH 5/5] btrfs: prepare btrfs_page_mkwrite() for larger folios Qu Wenruo
2025-02-21 12:22 ` Johannes Thumshirn
2025-02-21 11:23 ` [PATCH 0/5] btrfs: prepare for larger folios support Johannes Thumshirn
2025-02-21 12:34 ` Filipe Manana
2025-02-21 22:33 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=decd6725-230b-4723-8919-9d5959f5ada0@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox