From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 0/3] btrfs: fix problem with balance recovery and snap delete
Date: Fri, 18 Feb 2022 14:56:09 -0500 [thread overview]
Message-ID: <cover.1645214059.git.josef@toxicpanda.com> (raw)
v1->v2:
- reworked the fix based on Filipe's feedback. Instead of just doing all the
snapshot delete at mount time simply keep track of any in-progress drops.
Then gate relocation on those drops finishing. Once the drops finish we
unblock relocation and carry on like normal.
--- Original email ---
Hello,
I found a problem where we'll try to add refs to blocks that no longer have
references because we started a relocation while we had a half deleted snapshot
in the file system. This only occurs on a clean mount with a pending snapshot
delete in place. I saw this in production but lost the file system before I
could test my patch. However I reproduced it locally with some error injection.
Without my patch we'd fail to run delayed refs with the warning in the commit
message in the first patch, with my patch we mount and can use the file system.
The other two patches are just cleanups that i noticed while messing with this
code. Thanks,
Josef
Josef Bacik (3):
btrfs: do not start relocation until in progress drops are done
btrfs: use btrfs_fs_info for deleting snapshots and cleaner
btrfs: pass btrfs_fs_info to btrfs_recover_relocation
fs/btrfs/ctree.h | 15 ++++++++++++++-
fs/btrfs/disk-io.c | 19 ++++++++++++++-----
fs/btrfs/extent-tree.c | 7 +++++++
fs/btrfs/relocation.c | 19 ++++++++++++++++---
fs/btrfs/root-tree.c | 18 ++++++++++++++++++
fs/btrfs/transaction.c | 37 ++++++++++++++++++++++++++++++++++---
fs/btrfs/transaction.h | 3 ++-
7 files changed, 105 insertions(+), 13 deletions(-)
--
2.26.3
next reply other threads:[~2022-02-18 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 19:56 Josef Bacik [this message]
2022-02-18 19:56 ` [PATCH v2 1/3] btrfs: do not start relocation until in progress drops are done Josef Bacik
2022-02-21 12:38 ` Filipe Manana
2022-02-24 15:03 ` [btrfs] 0ac06c96a6: BUG:KASAN:use-after-free_in_btrfs_drop_snapshot kernel test robot
2022-02-18 19:56 ` [PATCH v2 2/3] btrfs: use btrfs_fs_info for deleting snapshots and cleaner Josef Bacik
2022-02-21 12:40 ` Filipe Manana
2022-02-18 19:56 ` [PATCH v2 3/3] btrfs: pass btrfs_fs_info to btrfs_recover_relocation Josef Bacik
2022-02-21 12:41 ` Filipe Manana
2022-02-21 16:20 ` [PATCH v2 0/3] btrfs: fix problem with balance recovery and snap delete David Sterba
2022-02-24 14:47 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1645214059.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox