From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM
Date: Fri, 5 Jun 2015 14:38:11 +0000 (UTC) [thread overview]
Message-ID: <pan.2015.06.05.14.38.11@googlemail.com> (raw)
In-Reply-To: 55719F55.8070803@suse.com
On Fri, 05 Jun 2015 09:08:37 -0400, Jeff Mahoney wrote:
>> which conflicts with Filipe's patch on Tuesday called "Btrfs: check
>> pending chunks when shrinking fs to avoid corruption":
>>
>> + if (contains_pending_extent(trans, device, &start, len)) {
>>
>> since trans (returned from start_transaction()) is a handle, not
>> the tx itself.
>>
>> ISTM that it should now pass trans->transaction instead..or
>> something.
>
> Yep. That's how you'd resolve that merge. The trans->transaction
> pointer will be valid for the life of the handle.
Good - that's what I've done locally for my branches. Thanks for
confirming. Good to know that I can still make sense of things.
It was more of a question/heads-up since it's not completely unheard of
for warnings to go unnoticed.. :)
cheers
Holger
next prev parent reply other threads:[~2015-06-05 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 14:47 [PATCH v3] btrfs: fix automatic blockgroup remove + discard jeffm
2015-06-03 14:47 ` [PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM jeffm
2015-06-04 11:15 ` Holger Hoffstätte
2015-06-05 13:08 ` Jeff Mahoney
2015-06-05 14:38 ` Holger Hoffstätte [this message]
2015-06-03 14:47 ` [PATCH 2/3] btrfs: explictly delete unused block groups in close_ctree and ro-remount jeffm
2015-06-03 14:47 ` [PATCH 3/3] btrfs: add missing discards when unpinning extents with -o discard jeffm
2015-06-08 14:12 ` Filipe David Manana
2015-06-09 20:48 ` Jeff Mahoney
2015-06-10 0:05 ` Jeff Mahoney
2015-06-10 22:52 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2015.06.05.14.38.11@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox