Linux CAN drivers development
 help / color / mirror / Atom feed
From: Andri Yngvason <andri.yngvason@marel.com>
To: "ZHU Yi (ST-FIR/ENG1-Zhu)" <Yi.Zhu5@cn.bosch.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: "hs@denx.de" <hs@denx.de>,
	"RUAN Tingquan (ST-FIR/ENG1-Zhu)" <Tingquan.Ruan@cn.bosch.com>,
	"Jonas Mark (ST-FIR/ENG1)" <Mark.Jonas@de.bosch.com>
Subject: RE: flexcan missing error state transitions
Date: Tue, 29 Aug 2017 13:41:38 +0000	[thread overview]
Message-ID: <150401409824.16044.6548310235605366193@maxwell> (raw)
In-Reply-To: <c5b11618c98a41108dfbe6cf034398f0@SGPMBX1017.APAC.bosch.com>

Hi Yi,

Quoting ZHU Yi (ST-FIR/ENG1-Zhu) (2017-08-29 08:49:46)
> > From: Andri Yngvason [mailto:andri.yngvason@marel.com]
> > Sent: Monday, August 28, 2017 7:23 PM
...
> > I have users who can change the baudrate but they can not change the device
> > tree. The baudrate can even be changed by service technicians. I.e. it's field
> > configurable. How would I configure the timeout to work well for rates between
> > 125k and 1M?
> Yes, the poll once approach assumes user have access to device-tree, otherwise
> a catch-all delay (based on the slowest bitrate) is required, which is less
> flexible than the periodic timer.
Actually, if it depends on the bitrate, then it would be easiest for everyone to
just set it accordingly in the code based on the bitrate without involving dt.
Anyway, that doesn't really matter, since it seems that we're going with the
"irq + suppress flooding" approach.

> 
> > 
> > Do you think that a periodic timer would load the system more than an IRQ-flood
> > due to a bad error situation?
> > 
> If not the hrtimer than most likely the periodic timer will not load the system
> more than IRQ flood, and we can configure the interval so it can even lower the
> system load than IRQ flood. However, the error irq + suppress flooding approach
> has the following benefits compare to the timer approach:
> 1. report state transitions in time
> 2. no need to handle the contention between irq and timer
> 3. no need to deal with how to specify the delay
OK, good enough.

Regards,
Andri

  parent reply	other threads:[~2017-08-29 13:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18  7:47 flexcan missing error state transitions ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-21 16:18 ` Andri Yngvason
2017-08-21 17:13   ` AW: " Jonas Mark (ST-FIR/ENG1)
2017-08-21 18:21     ` Andri Yngvason
2017-08-22 13:50       ` AW: " Jonas Mark (ST-FIR/ENG1)
2017-08-22 14:06         ` Marc Kleine-Budde
2017-08-22 19:03           ` AW: " Jonas Mark (ST-FIR/ENG1)
2017-08-24  9:40             ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-25 17:16               ` Andri Yngvason
2017-08-27 10:57           ` Wolfgang Grandegger
2017-08-28  4:21             ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-28  8:33               ` Wolfgang Grandegger
2017-08-29  8:49                 ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-29  9:38                   ` Wolfgang Grandegger
2017-08-30  1:39                     ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-29 11:17                   ` Wolfgang Grandegger
2017-08-30  4:22                     ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-30  6:25                       ` Wolfgang Grandegger
2017-08-30  6:50                         ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-30  7:15                           ` Wolfgang Grandegger
2017-08-30  9:05                             ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-30 10:59                               ` Wolfgang Grandegger
2017-08-31  8:33                                 ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-31  9:53                                   ` Wolfgang Grandegger
2017-09-01  8:24                                     ` ZHU Yi (ST-FIR/ENG1-Zhu)
2017-08-29 13:41                   ` Andri Yngvason [this message]
2017-08-22 14:14         ` AW: AW: " Andri Yngvason
2017-08-27 12:55           ` Wolfgang Grandegger
  -- strict thread matches above, loose matches on Subject: below --
2017-08-26  5:46 朱燚
2017-08-28 11:23 ` Andri Yngvason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150401409824.16044.6548310235605366193@maxwell \
    --to=andri.yngvason@marel.com \
    --cc=Mark.Jonas@de.bosch.com \
    --cc=Tingquan.Ruan@cn.bosch.com \
    --cc=Yi.Zhu5@cn.bosch.com \
    --cc=hs@denx.de \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox