From: Wolfgang Grandegger <wg@grandegger.com>
To: Andri Yngvason <andri.yngvason@marel.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Subject: Re: Inconsistent error state transition error frames
Date: Tue, 09 Sep 2014 17:41:12 +0200 [thread overview]
Message-ID: <1a51435a44c2ebd32cca3feee3799af3@grandegger.com> (raw)
In-Reply-To: <540F1396.2030702@marel.com>
On Tue, 9 Sep 2014 14:49:58 +0000, Andri Yngvason
<andri.yngvason@marel.com> wrote:
> On þri 9.sep 2014 13:53, Wolfgang Grandegger wrote:
>> On Tue, 9 Sep 2014 11:59:28 +0000, Andri Yngvason
>> <andri.yngvason@marel.com> wrote:
>>> On þri 9.sep 2014 10:48, Wolfgang Grandegger wrote:
...
>>> haven't posted patches to the kernel before, but I've read the
>>> documentation and hopefully I'll get it right. ;)
>> Don't worry. You will learn it quickly.
> Thanks for the reassurance. Which branch should I rebase against,
> linux-can or linux-can-next?
linux-can-next please.
...
> It seems that 'data' is fully occupied, although 'data[5..7]' isn't
> reserved for anything specific but rather "controller specific
> additional information". Could we maybe put the version into data 5, 6
or
> 7?
data[6..7] is used for the tx and rx error counts.
> Another option is to place it into the 3 or 4 msb of the id; something
> like this:
> #define CAN_ERR_VERSION_MASK 0x1E000000U // Note: CAN_ERR_MASK is
> 0x1FFFFFFFU
>
> Are 15 possible versions enough (or even too much)?
I would prefer an unsued field otherwise old can-util tools will report
rubbish. data[5] sounds good. But we should add a version number only
if we really need it.
Wolfgang.
next prev parent reply other threads:[~2014-09-09 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 16:26 Inconsistent error state transition error frames Andri Yngvason
2014-09-08 16:36 ` Marc Kleine-Budde
2014-09-09 10:48 ` Wolfgang Grandegger
2014-09-09 11:59 ` Andri Yngvason
2014-09-09 13:53 ` Wolfgang Grandegger
2014-09-09 14:49 ` Andri Yngvason
2014-09-09 15:41 ` Wolfgang Grandegger [this message]
2014-09-09 18:08 ` Oliver Hartkopp
2014-09-10 10:19 ` Andri Yngvason
2014-09-10 10:29 ` Marc Kleine-Budde
2014-09-10 11:53 ` Wolfgang Grandegger
2014-09-10 19:08 ` Oliver Hartkopp
2014-09-11 10:03 ` Andri Yngvason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a51435a44c2ebd32cca3feee3799af3@grandegger.com \
--to=wg@grandegger.com \
--cc=andri.yngvason@marel.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox