Linux CAN drivers development
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andri Yngvason <Andri.Yngvason@marel.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: Inconsistent error state transition error frames
Date: Mon, 08 Sep 2014 18:36:38 +0200	[thread overview]
Message-ID: <540DDB16.8010304@pengutronix.de> (raw)
In-Reply-To: <7EAA3DE6DC6BA14D830C95541CC66EBC9F72FED6@GRBSR0004.marel.net>

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

On 09/08/2014 06:26 PM, Andri Yngvason wrote:
> I've been working on a userspace program to monitor the CAN bus and I
> found that it only works as expected on one platform (flexcan). The
> problem is that on most other platforms, no error frame is emitted
> when the controller transitions back to error-active state. I see
> that you've already discussed this on this list here:
> http://thread.gmane.org/gmane.linux.can/201
>
> Why hasn't this been resolved?

I assume no one needed this feature so far, I assume. And/or cared not
enough to upstream these patches.

> I already patched the mscan and sja1000 drivers myself, and I was
> considering submitting them, but since you've already done some work
> on this (which I believe is superior to mine), my work is unlikely to

Wolfgang mentioned in this mail, that he had some patches back than. Do
you still have them, Wolfgang?

> be of any consequence to this community, except to show that this
> inconsistency does indeed result in wasted effort and frustration.

Feel free to post your patches.

> Of course, I'll help out if I can, e.g. by testing on the platforms
> that I have available.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2014-09-08 16:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 16:26 Inconsistent error state transition error frames Andri Yngvason
2014-09-08 16:36 ` Marc Kleine-Budde [this message]
2014-09-09 10:48   ` Wolfgang Grandegger
2014-09-09 11:59     ` Andri Yngvason
2014-09-09 13:53       ` Wolfgang Grandegger
2014-09-09 14:49         ` Andri Yngvason
2014-09-09 15:41           ` Wolfgang Grandegger
2014-09-09 18:08             ` Oliver Hartkopp
2014-09-10 10:19               ` Andri Yngvason
2014-09-10 10:29                 ` Marc Kleine-Budde
2014-09-10 11:53                   ` Wolfgang Grandegger
2014-09-10 19:08                     ` Oliver Hartkopp
2014-09-11 10:03                       ` Andri Yngvason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540DDB16.8010304@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=Andri.Yngvason@marel.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox