Re: [PATCH] can: ifi: use correct register to read rx status

Re: [PATCH] can: ifi: use correct register to read rx status

[Marek Vasut]

Hi,

I was notified about this patch recently, unfortunately I was not on CC
on the original submission, so I was unable to review/test this patch.
Nice catch though, thanks.

Which version of the core do you use ? Can you also share value of
register 0x54 and 0x58 ?

Thanks
-- 
Best regards,
Marek Vasut

Re: [PATCH] can: ifi: use correct register to read rx status

[Markus Marb]

Hi,

> Which version of the core do you use ? Can you also share value of
> register 0x54 and 0x58 ?
I am using core version 0x020F5B14 (register 0x54).
Register 0x58 is fixed i guess ? It holds 0xD073CAFD.

Regards,
Markus Marb

Re: [PATCH] can: ifi: use correct register to read rx status

[Marek Vasut]

On 04/10/2017 10:07 PM, Markus Marb wrote:
> Hi,

Hi!

>> Which version of the core do you use ? Can you also share value of
>> register 0x54 and 0x58 ?
> I am using core version 0x020F5B14 (register 0x54).

Thanks!

> Register 0x58 is fixed i guess ? It holds 0xD073CAFD.
> 
> Regards,
> Markus Marb
> 


-- 
Best regards,
Marek Vasut

[PATCH] can: ifi: use correct register to read rx status

[Markus Marb]

The incorrect offset was used when trying to read the RXSTCMD register.

Signed-off-by: Markus Marb <markus@marb.org>
---
 drivers/net/can/ifi_canfd/ifi_canfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/ifi_canfd/ifi_canfd.c b/drivers/net/can/ifi_canfd/ifi_canfd.c
index 138f5ae..4d1fe8d 100644
--- a/drivers/net/can/ifi_canfd/ifi_canfd.c
+++ b/drivers/net/can/ifi_canfd/ifi_canfd.c
@@ -557,7 +557,7 @@ static int ifi_canfd_poll(struct napi_struct *napi, int quota)
 	int work_done = 0;
 
 	u32 stcmd = readl(priv->base + IFI_CANFD_STCMD);
-	u32 rxstcmd = readl(priv->base + IFI_CANFD_STCMD);
+	u32 rxstcmd = readl(priv->base + IFI_CANFD_RXSTCMD);
 	u32 errctr = readl(priv->base + IFI_CANFD_ERROR_CTR);
 
 	/* Handle bus state changes */
-- 
2.7.4

Re: [PATCH] can: ifi: use correct register to read rx status

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 481 bytes --]

On 03/17/2017 11:14 PM, Markus Marb wrote:
> The incorrect offset was used when trying to read the RXSTCMD register.
> 
> Signed-off-by: Markus Marb <markus@marb.org>

Applied to can.

tnx,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]