[PATCH] can: use namespace aware procfs function

[PATCH] can: use namespace aware procfs function

[Oliver Hartkopp]

Fixes 'can: complete initial namespace support'

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
 net/can/proc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/can/proc.c b/net/can/proc.c
index 1a7d95e2335b..83045f00c63c 100644
--- a/net/can/proc.c
+++ b/net/can/proc.c
@@ -272,7 +272,7 @@ static int can_stats_proc_show(struct seq_file *m, void *v)
 
 static int can_stats_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_stats_proc_show);
 }
 
 static const struct file_operations can_stats_proc_fops = {
@@ -306,7 +306,7 @@ static int can_reset_stats_proc_show(struct seq_file *m, void *v)
 
 static int can_reset_stats_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_reset_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_reset_stats_proc_show);
 }
 
 static const struct file_operations can_reset_stats_proc_fops = {
@@ -325,7 +325,7 @@ static int can_version_proc_show(struct seq_file *m, void *v)
 
 static int can_version_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_version_proc_show, NULL);
+	return single_open_net(inode, file, can_version_proc_show);
 }
 
 static const struct file_operations can_version_proc_fops = {
-- 
2.11.0

Fwd: [PATCH] can: use namespace aware procfs function

[Oliver Hartkopp]

Hey Marc,

can you squash this fix into my original RFC v2 patch?

I missed this change which then leads to a segfault.

Alternatively I can send a v3.

Regards,
Oliver


-------- Forwarded Message --------
Subject: [PATCH] can: use namespace aware procfs function
Date: Sat, 15 Apr 2017 20:06:29 +0200
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: linux-can@vger.kernel.org
CC: Oliver Hartkopp <socketcan@hartkopp.net>

Fixes 'can: complete initial namespace support'

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
  net/can/proc.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/can/proc.c b/net/can/proc.c
index 1a7d95e2335b..83045f00c63c 100644
--- a/net/can/proc.c
+++ b/net/can/proc.c
@@ -272,7 +272,7 @@ static int can_stats_proc_show(struct seq_file *m, 
void *v)
   static int can_stats_proc_open(struct inode *inode, struct file *file)
  {
-	return single_open(file, can_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_stats_proc_show);
  }
   static const struct file_operations can_stats_proc_fops = {
@@ -306,7 +306,7 @@ static int can_reset_stats_proc_show(struct seq_file 
*m, void *v)
   static int can_reset_stats_proc_open(struct inode *inode, struct file 
*file)
  {
-	return single_open(file, can_reset_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_reset_stats_proc_show);
  }
   static const struct file_operations can_reset_stats_proc_fops = {
@@ -325,7 +325,7 @@ static int can_version_proc_show(struct seq_file *m, 
void *v)
   static int can_version_proc_open(struct inode *inode, struct file *file)
  {
-	return single_open(file, can_version_proc_show, NULL);
+	return single_open_net(inode, file, can_version_proc_show);
  }
   static const struct file_operations can_version_proc_fops = {
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH] can: use namespace aware procfs function

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]

On 04/15/2017 08:12 PM, Oliver Hartkopp wrote:
> Hey Marc,
> 
> can you squash this fix into my original RFC v2 patch?

will do.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fwd: [PATCH] can: use namespace aware procfs function

[Oliver Hartkopp]

On 04/15/2017 08:21 PM, Marc Kleine-Budde wrote:
> On 04/15/2017 08:12 PM, Oliver Hartkopp wrote:
>> Hey Marc,
>>
>> can you squash this fix into my original RFC v2 patch?
>
> will do.
>

Great!

I finalized a namespace patch for CAN BCM some minutes ago.

I'll do some more testing tomorrow and post it then.

Best regards,
Oliver

Re: Fwd: [PATCH] can: use namespace aware procfs function

[Oliver Hartkopp]

On 04/15/2017 10:56 PM, Oliver Hartkopp wrote:
> On 04/15/2017 08:21 PM, Marc Kleine-Budde wrote:
>> On 04/15/2017 08:12 PM, Oliver Hartkopp wrote:
>>> can you squash this fix into my original RFC v2 patch?
>>
>> will do.
>>
>
> Great!
>
> I finalized a namespace patch for CAN BCM some minutes ago.
>
> I'll do some more testing tomorrow and post it then.

Done :-)

Will you push these patches to can-next?

Regards,
Oliver

Re: Fwd: [PATCH] can: use namespace aware procfs function

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 790 bytes --]

On 04/17/2017 12:55 PM, Oliver Hartkopp wrote:
> On 04/15/2017 10:56 PM, Oliver Hartkopp wrote:
>> On 04/15/2017 08:21 PM, Marc Kleine-Budde wrote:
>>> On 04/15/2017 08:12 PM, Oliver Hartkopp wrote:
>>>> can you squash this fix into my original RFC v2 patch?
>>>
>>> will do.
>>>
>>
>> Great!
>>
>> I finalized a namespace patch for CAN BCM some minutes ago.
>>
>> I'll do some more testing tomorrow and post it then.
> 
> Done :-)
> 
> Will you push these patches to can-next?

done.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]