* [PATCH net 06/16] can: add missing attribute validation for termination
[not found] <20200303050526.4088735-1-kuba@kernel.org>
@ 2020-03-03 5:05 ` Jakub Kicinski
2020-03-03 19:58 ` Oliver Hartkopp
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2020-03-03 5:05 UTC (permalink / raw)
To: davem
Cc: netdev, Jakub Kicinski, Wolfgang Grandegger, Marc Kleine-Budde,
Oliver Hartkopp, linux-can
Add missing attribute validation for IFLA_CAN_TERMINATION
to the netlink policy.
Fixes: 12a6075cabc0 ("can: dev: add CAN interface termination API")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Wolfgang Grandegger <wg@grandegger.com>
CC: Marc Kleine-Budde <mkl@pengutronix.de>
CC: Oliver Hartkopp <socketcan@hartkopp.net>
CC: linux-can@vger.kernel.org
---
drivers/net/can/dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 6ee06a49fb4c..68834a2853c9 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -883,6 +883,7 @@ static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
= { .len = sizeof(struct can_bittiming) },
[IFLA_CAN_DATA_BITTIMING_CONST]
= { .len = sizeof(struct can_bittiming_const) },
+ [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
};
static int can_validate(struct nlattr *tb[], struct nlattr *data[],
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net 06/16] can: add missing attribute validation for termination
2020-03-03 5:05 ` [PATCH net 06/16] can: add missing attribute validation for termination Jakub Kicinski
@ 2020-03-03 19:58 ` Oliver Hartkopp
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Hartkopp @ 2020-03-03 19:58 UTC (permalink / raw)
To: Jakub Kicinski, davem
Cc: netdev, Wolfgang Grandegger, Marc Kleine-Budde, linux-can
On 03/03/2020 06.05, Jakub Kicinski wrote:
> Add missing attribute validation for IFLA_CAN_TERMINATION
> to the netlink policy.
>
> Fixes: 12a6075cabc0 ("can: dev: add CAN interface termination API")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: Wolfgang Grandegger <wg@grandegger.com>
> CC: Marc Kleine-Budde <mkl@pengutronix.de>
> CC: Oliver Hartkopp <socketcan@hartkopp.net>
> CC: linux-can@vger.kernel.org
> ---
> drivers/net/can/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index 6ee06a49fb4c..68834a2853c9 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -883,6 +883,7 @@ static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
> = { .len = sizeof(struct can_bittiming) },
> [IFLA_CAN_DATA_BITTIMING_CONST]
> = { .len = sizeof(struct can_bittiming_const) },
> + [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
> };
>
> static int can_validate(struct nlattr *tb[], struct nlattr *data[],
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks Jakub for catching all these missing defs!
Best regards,
Oliver
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-03 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200303050526.4088735-1-kuba@kernel.org>
2020-03-03 5:05 ` [PATCH net 06/16] can: add missing attribute validation for termination Jakub Kicinski
2020-03-03 19:58 ` Oliver Hartkopp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox