* [PATCH 3/7] can: kvaser_pciefd: select CONFIG_CRC32
[not found] <20210103213645.1994783-1-arnd@kernel.org>
@ 2021-01-03 21:36 ` Arnd Bergmann
2021-01-04 8:43 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-01-03 21:36 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Jakub Kicinski
Cc: Arnd Bergmann, Henning Colliander, Christer Beskow,
Jimmy Assarsson, linux-can, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without crc32, this driver fails to link:
arm-linux-gnueabi-ld: drivers/net/can/kvaser_pciefd.o: in function `kvaser_pciefd_probe':
kvaser_pciefd.c:(.text+0x2b0): undefined reference to `crc32_be'
Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/can/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 424970939fd4..1c28eade6bec 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -123,6 +123,7 @@ config CAN_JANZ_ICAN3
config CAN_KVASER_PCIEFD
depends on PCI
tristate "Kvaser PCIe FD cards"
+ select CRC32
help
This is a driver for the Kvaser PCI Express CAN FD family.
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/7] can: kvaser_pciefd: select CONFIG_CRC32
2021-01-03 21:36 ` [PATCH 3/7] can: kvaser_pciefd: select CONFIG_CRC32 Arnd Bergmann
@ 2021-01-04 8:43 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2021-01-04 8:43 UTC (permalink / raw)
To: Arnd Bergmann, Wolfgang Grandegger, David S. Miller,
Jakub Kicinski
Cc: Arnd Bergmann, Henning Colliander, Christer Beskow,
Jimmy Assarsson, linux-can, netdev, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 776 bytes --]
On 1/3/21 10:36 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without crc32, this driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/can/kvaser_pciefd.o: in function `kvaser_pciefd_probe':
> kvaser_pciefd.c:(.text+0x2b0): undefined reference to `crc32_be'
>
> Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regrards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-04 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210103213645.1994783-1-arnd@kernel.org>
2021-01-03 21:36 ` [PATCH 3/7] can: kvaser_pciefd: select CONFIG_CRC32 Arnd Bergmann
2021-01-04 8:43 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox