From: "Daniel Glöckner" <dg@emlix.com>
To: netdev@vger.kernel.org, linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Softirq error with mcp251xfd driver
Date: Wed, 10 Mar 2021 07:46:26 +0100 [thread overview]
Message-ID: <20210310064626.GA11893@homes.emlix.com> (raw)
Hi,
the mcp251xfd driver uses a threaded irq handler to queue skbs with the
can_rx_offload_* helpers. I get the following error on every packet until
the rate limit kicks in:
NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
Adding local_bh_disable/local_bh_enable around the can_rx_offload_* calls
gets rid of the error, but is that the correct way to fix this?
Internally the can_rx_offload code uses spin_lock_irqsave to safely
manipulate its queue.
Best regards,
Daniel
next reply other threads:[~2021-03-10 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 6:46 Daniel Glöckner [this message]
2021-03-10 7:13 ` Softirq error with mcp251xfd driver Marc Kleine-Budde
2021-03-10 21:22 ` Daniel Glöckner
2021-03-10 21:56 ` Daniel Glöckner
2021-03-11 12:20 ` Marc Kleine-Budde
2021-03-11 11:55 ` Marc Kleine-Budde
2021-04-22 8:25 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310064626.GA11893@homes.emlix.com \
--to=dg@emlix.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox