From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: Jeroen Hofstee <jhofstee@victronenergy.com>
Subject: Re: [PATCH 6/6] can: gs_usb: support reading error counters
Date: Thu, 6 Oct 2022 18:37:57 +0200 [thread overview]
Message-ID: <20221006163757.whj3q2bavfu6mt4k@pengutronix.de> (raw)
In-Reply-To: <20221006162452.200322-7-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On 06.10.2022 18:24:52, Marc Kleine-Budde wrote:
> From: Jeroen Hofstee <jhofstee@victronenergy.com>
>
> the format of this message is a bit weird, single bytes would be
> sufficient. At the moment it uses the existing struct gs_device_state.
From my point of view this looks good. The struct gs_device_state wasn't
used at all, yet! This is a good use of it.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-06 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 16:24 [PATCH 0/6] can: gs_usb: new features: GS_CAN_FEATURE_GET_STATE, GS_CAN_FEATURE_BERR_REPORTING Marc Kleine-Budde
2022-10-06 16:24 ` [PATCH 1/6] can: gs_usb: gs_can_open(): allow loopback and listen only at the same time Marc Kleine-Budde
2022-10-06 16:24 ` [PATCH 2/6] can: gs_usb: gs_can_open(): sort checks for ctrlmode Marc Kleine-Budde
2022-10-06 16:24 ` [PATCH 3/6] can: gs_usb: gs_can_open(): merge setting of timestamp flags and init Marc Kleine-Budde
2022-10-06 16:24 ` [PATCH 4/6] can: gs_usb: add ability to enable / disable berr rerporting Marc Kleine-Budde
2022-10-06 16:36 ` Marc Kleine-Budde
2022-10-07 18:30 ` Jeroen Hofstee
2022-10-08 15:39 ` Jeroen Hofstee
2022-10-10 7:00 ` Marc Kleine-Budde
2022-10-08 22:11 ` Jeroen Hofstee
2022-10-10 7:03 ` Marc Kleine-Budde
2022-10-06 16:24 ` [PATCH 5/6] can: gs_usb: document GS_CAN_FEATURE_GET_STATE Marc Kleine-Budde
2022-10-06 16:24 ` [PATCH 6/6] can: gs_usb: support reading error counters Marc Kleine-Budde
2022-10-06 16:37 ` Marc Kleine-Budde [this message]
2022-10-06 16:28 ` [PATCH 0/6] can: gs_usb: new features: GS_CAN_FEATURE_GET_STATE, GS_CAN_FEATURE_BERR_REPORTING Marc Kleine-Budde
2022-10-07 18:59 ` Jeroen Hofstee
2022-10-10 6:30 ` Marc Kleine-Budde
2022-10-07 18:46 ` Jeroen Hofstee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006163757.whj3q2bavfu6mt4k@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=jhofstee@victronenergy.com \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox