Linux CAN drivers development
 help / color / mirror / Atom feed
* [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan
@ 2024-06-29  2:17 Frank Li
  2024-07-01 17:54 ` Rob Herring (Arm)
  2024-07-04 10:07 ` Marc Kleine-Budde
  0 siblings, 2 replies; 5+ messages in thread
From: Frank Li @ 2024-06-29  2:17 UTC (permalink / raw)
  To: Marc Kleine-Budde, Vincent Mailhol, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, open list:CAN NETWORK DRIVERS,
	open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Add common 'can-transceiver' children node for fsl,flexcan.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: can@2180000: 'can-transceiver' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/net/can/fsl,flexcan.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- rework commit message and add fix CHECK_DTBS warning
- Add unevaluatedProperties: false
---
 Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
index f197d9b516bb2..a4261a201fdb6 100644
--- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
+++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
@@ -80,6 +80,10 @@ properties:
       node then controller is assumed to be little endian. If this property is
       present then controller is assumed to be big endian.
 
+  can-transceiver:
+    $ref: can-transceiver.yaml#
+    unevaluatedProperties: false
+
   fsl,stop-mode:
     description: |
       Register bits of stop mode control.
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan
  2024-06-29  2:17 [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan Frank Li
@ 2024-07-01 17:54 ` Rob Herring (Arm)
  2024-07-04 10:07 ` Marc Kleine-Budde
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2024-07-01 17:54 UTC (permalink / raw)
  To: Frank Li
  Cc: Jakub Kicinski, Marc Kleine-Budde, Vincent Mailhol, Conor Dooley,
	linux-kernel, devicetree, Krzysztof Kozlowski, Eric Dumazet,
	linux-can, Paolo Abeni, David S. Miller, imx, netdev


On Fri, 28 Jun 2024 22:17:54 -0400, Frank Li wrote:
> Add common 'can-transceiver' children node for fsl,flexcan.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: can@2180000: 'can-transceiver' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/net/can/fsl,flexcan.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - rework commit message and add fix CHECK_DTBS warning
> - Add unevaluatedProperties: false
> ---
>  Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan
  2024-06-29  2:17 [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan Frank Li
  2024-07-01 17:54 ` Rob Herring (Arm)
@ 2024-07-04 10:07 ` Marc Kleine-Budde
  2024-08-01 21:11   ` Frank Li
  1 sibling, 1 reply; 5+ messages in thread
From: Marc Kleine-Budde @ 2024-07-04 10:07 UTC (permalink / raw)
  To: Frank Li
  Cc: Vincent Mailhol, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:CAN NETWORK DRIVERS, open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

On 28.06.2024 22:17:54, Frank Li wrote:
> Add common 'can-transceiver' children node for fsl,flexcan.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: can@2180000: 'can-transceiver' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/net/can/fsl,flexcan.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied to linux-can-next.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan
  2024-07-04 10:07 ` Marc Kleine-Budde
@ 2024-08-01 21:11   ` Frank Li
  2024-08-05 14:44     ` Marc Kleine-Budde
  0 siblings, 1 reply; 5+ messages in thread
From: Frank Li @ 2024-08-01 21:11 UTC (permalink / raw)
  To: Marc Kleine-Budde
  Cc: Vincent Mailhol, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:CAN NETWORK DRIVERS, open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Thu, Jul 04, 2024 at 12:07:02PM +0200, Marc Kleine-Budde wrote:
> On 28.06.2024 22:17:54, Frank Li wrote:
> > Add common 'can-transceiver' children node for fsl,flexcan.
> >
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: can@2180000: 'can-transceiver' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id: http://devicetree.org/schemas/net/can/fsl,flexcan.yaml#
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> Applied to linux-can-next.

I have not seen it at v6.11-rc1. Anything wrong?

Frank

>
> Thanks,
> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan
  2024-08-01 21:11   ` Frank Li
@ 2024-08-05 14:44     ` Marc Kleine-Budde
  0 siblings, 0 replies; 5+ messages in thread
From: Marc Kleine-Budde @ 2024-08-05 14:44 UTC (permalink / raw)
  To: Frank Li
  Cc: Vincent Mailhol, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:CAN NETWORK DRIVERS, open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On 01.08.2024 17:11:21, Frank Li wrote:
> On Thu, Jul 04, 2024 at 12:07:02PM +0200, Marc Kleine-Budde wrote:
> > On 28.06.2024 22:17:54, Frank Li wrote:
> > > Add common 'can-transceiver' children node for fsl,flexcan.
> > >
> > > Fix below warning:
> > > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: can@2180000: 'can-transceiver' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >         from schema $id: http://devicetree.org/schemas/net/can/fsl,flexcan.yaml#
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >
> > Applied to linux-can-next.
> 
> I have not seen it at v6.11-rc1. Anything wrong?

No, it go mainline by v6.12.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-05 15:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-29  2:17 [PATCH v2 1/1] dt-bindings: can: fsl,flexcan: add common 'can-transceiver' for fsl,flexcan Frank Li
2024-07-01 17:54 ` Rob Herring (Arm)
2024-07-04 10:07 ` Marc Kleine-Budde
2024-08-01 21:11   ` Frank Li
2024-08-05 14:44     ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox