From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de, Marc Kleine-Budde <mkl@pengutronix.de>,
Alibek Omarov <a1ba.omarov@gmail.com>,
Heiko Stuebner <heiko@sntech.de>
Subject: [PATCH net-next 20/20] can: rockchip_canfd: add support for CAN_CTRLMODE_BERR_REPORTING
Date: Wed, 4 Sep 2024 11:38:55 +0200 [thread overview]
Message-ID: <20240904094218.1925386-21-mkl@pengutronix.de> (raw)
In-Reply-To: <20240904094218.1925386-1-mkl@pengutronix.de>
Add support for Bus Error Reporting.
Tested-by: Alibek Omarov <a1ba.omarov@gmail.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patch.msgid.link/20240904-rockchip-canfd-v5-20-8ae22bcb27cc@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
.../net/can/rockchip/rockchip_canfd-core.c | 25 +++++++++++++------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/net/can/rockchip/rockchip_canfd-core.c b/drivers/net/can/rockchip/rockchip_canfd-core.c
index 8853f6a135da..6883153e8fc1 100644
--- a/drivers/net/can/rockchip/rockchip_canfd-core.c
+++ b/drivers/net/can/rockchip/rockchip_canfd-core.c
@@ -293,6 +293,12 @@ static void rkcanfd_chip_start(struct rkcanfd_priv *priv)
RKCANFD_REG_INT_OVERLOAD_INT |
RKCANFD_REG_INT_TX_FINISH_INT;
+ /* Do not mask the bus error interrupt if the bus error
+ * reporting is requested.
+ */
+ if (!(priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING))
+ priv->reg_int_mask_default |= RKCANFD_REG_INT_ERROR_INT;
+
memset(&priv->bec, 0x0, sizeof(priv->bec));
rkcanfd_chip_fifo_setup(priv);
@@ -533,14 +539,16 @@ static int rkcanfd_handle_error_int(struct rkcanfd_priv *priv)
if (!reg_ec)
return 0;
- skb = rkcanfd_alloc_can_err_skb(priv, &cf, ×tamp);
- if (cf) {
- struct can_berr_counter bec;
+ if (priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING) {
+ skb = rkcanfd_alloc_can_err_skb(priv, &cf, ×tamp);
+ if (cf) {
+ struct can_berr_counter bec;
- rkcanfd_get_berr_counter_corrected(priv, &bec);
- cf->can_id |= CAN_ERR_PROT | CAN_ERR_BUSERROR | CAN_ERR_CNT;
- cf->data[6] = bec.txerr;
- cf->data[7] = bec.rxerr;
+ rkcanfd_get_berr_counter_corrected(priv, &bec);
+ cf->can_id |= CAN_ERR_PROT | CAN_ERR_BUSERROR | CAN_ERR_CNT;
+ cf->data[6] = bec.txerr;
+ cf->data[7] = bec.rxerr;
+ }
}
rkcanfd_handle_error_int_reg_ec(priv, cf, reg_ec);
@@ -899,7 +907,8 @@ static int rkcanfd_probe(struct platform_device *pdev)
priv->can.clock.freq = clk_get_rate(priv->clks[0].clk);
priv->can.bittiming_const = &rkcanfd_bittiming_const;
priv->can.data_bittiming_const = &rkcanfd_data_bittiming_const;
- priv->can.ctrlmode_supported = CAN_CTRLMODE_LOOPBACK;
+ priv->can.ctrlmode_supported = CAN_CTRLMODE_LOOPBACK |
+ CAN_CTRLMODE_BERR_REPORTING;
if (!(priv->devtype_data.quirks & RKCANFD_QUIRK_CANFD_BROKEN))
priv->can.ctrlmode_supported |= CAN_CTRLMODE_FD;
priv->can.do_set_mode = rkcanfd_set_mode;
--
2.45.2
next prev parent reply other threads:[~2024-09-04 9:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 9:38 [PATCH net-next 0/20] pull-request: can-next 2024-09-04 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 01/20] dt-bindings: can: rockchip_canfd: add rockchip CAN-FD controller Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 02/20] arm64: dts: rockchip: add CAN-FD controller nodes to rk3568 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 03/20] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces Marc Kleine-Budde
2024-09-04 11:51 ` Krzysztof Kozlowski
2024-09-04 11:57 ` Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 04/20] can: rockchip_canfd: add driver for Rockchip CAN-FD controller Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 05/20] can: rockchip_canfd: add quirks for errata workarounds Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 06/20] can: rockchip_canfd: add quirk for broken CAN-FD support Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 07/20] can: rockchip_canfd: add support for rk3568v3 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 08/20] can: rockchip_canfd: add notes about known issues Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 09/20] can: rockchip_canfd: rkcanfd_handle_rx_int_one(): implement workaround for erratum 5: check for empty FIFO Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 10/20] can: rockchip_canfd: rkcanfd_register_done(): add warning for erratum 5 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 11/20] can: rockchip_canfd: add TX PATH Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 12/20] can: rockchip_canfd: implement workaround for erratum 6 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 13/20] can: rockchip_canfd: implement workaround for erratum 12 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 14/20] can: rockchip_canfd: rkcanfd_get_berr_counter_corrected(): work around broken {RX,TX}ERRORCNT register Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 15/20] can: rockchip_canfd: add stats support for errata workarounds Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 16/20] can: rockchip_canfd: prepare to use full TX-FIFO depth Marc Kleine-Budde
2024-09-04 16:13 ` Christoph Fritz
2024-09-05 6:35 ` Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 17/20] can: rockchip_canfd: enable full TX-FIFO depth of 2 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 18/20] can: rockchip_canfd: add hardware timestamping support Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 19/20] can: rockchip_canfd: add support for CAN_CTRLMODE_LOOPBACK Marc Kleine-Budde
2024-09-04 9:38 ` Marc Kleine-Budde [this message]
2024-09-04 12:56 ` [PATCH net-next 0/20] pull-request: can-next 2024-09-04 Marc Kleine-Budde
2024-09-04 13:04 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904094218.1925386-21-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=a1ba.omarov@gmail.com \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox