From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Alibek Omarov <a1ba.omarov@gmail.com>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH net-next 16/20] can: rockchip_canfd: prepare to use full TX-FIFO depth
Date: Thu, 5 Sep 2024 08:35:46 +0200 [thread overview]
Message-ID: <20240905-funky-unbiased-oxpecker-eae021-mkl@pengutronix.de> (raw)
In-Reply-To: <28a20a6697dbe610bd13829baa9d188ef22a1742.camel@googlemail.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On 04.09.2024 18:13:21, Christoph Fritz wrote:
> > The workaround for the chips that are affected by erratum 6, i.e. EFF
> > frames may be send as standard frames, is to re-send the EFF frame.
> > This means the driver cannot queue the next frame for sending, as long
> > ad the EFF frame has not been successfully send out.
>
> just a nitpick, shouldn't it be "as" instead of "ad" ?
Fixed. But I will not send another PR unless there is another problem :)
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-09-05 6:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 9:38 [PATCH net-next 0/20] pull-request: can-next 2024-09-04 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 01/20] dt-bindings: can: rockchip_canfd: add rockchip CAN-FD controller Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 02/20] arm64: dts: rockchip: add CAN-FD controller nodes to rk3568 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 03/20] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces Marc Kleine-Budde
2024-09-04 11:51 ` Krzysztof Kozlowski
2024-09-04 11:57 ` Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 04/20] can: rockchip_canfd: add driver for Rockchip CAN-FD controller Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 05/20] can: rockchip_canfd: add quirks for errata workarounds Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 06/20] can: rockchip_canfd: add quirk for broken CAN-FD support Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 07/20] can: rockchip_canfd: add support for rk3568v3 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 08/20] can: rockchip_canfd: add notes about known issues Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 09/20] can: rockchip_canfd: rkcanfd_handle_rx_int_one(): implement workaround for erratum 5: check for empty FIFO Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 10/20] can: rockchip_canfd: rkcanfd_register_done(): add warning for erratum 5 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 11/20] can: rockchip_canfd: add TX PATH Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 12/20] can: rockchip_canfd: implement workaround for erratum 6 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 13/20] can: rockchip_canfd: implement workaround for erratum 12 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 14/20] can: rockchip_canfd: rkcanfd_get_berr_counter_corrected(): work around broken {RX,TX}ERRORCNT register Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 15/20] can: rockchip_canfd: add stats support for errata workarounds Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 16/20] can: rockchip_canfd: prepare to use full TX-FIFO depth Marc Kleine-Budde
2024-09-04 16:13 ` Christoph Fritz
2024-09-05 6:35 ` Marc Kleine-Budde [this message]
2024-09-04 9:38 ` [PATCH net-next 17/20] can: rockchip_canfd: enable full TX-FIFO depth of 2 Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 18/20] can: rockchip_canfd: add hardware timestamping support Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 19/20] can: rockchip_canfd: add support for CAN_CTRLMODE_LOOPBACK Marc Kleine-Budde
2024-09-04 9:38 ` [PATCH net-next 20/20] can: rockchip_canfd: add support for CAN_CTRLMODE_BERR_REPORTING Marc Kleine-Budde
2024-09-04 12:56 ` [PATCH net-next 0/20] pull-request: can-next 2024-09-04 Marc Kleine-Budde
2024-09-04 13:04 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905-funky-unbiased-oxpecker-eae021-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=a1ba.omarov@gmail.com \
--cc=chf.fritz@googlemail.com \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox