Re: [PATCH] can: rockchip_canfd: Drop obsolete dependency on COMPILE_TEST

[Jean Delvare <jdelvare@suse.de>]

Hi Geert,

On Tue, 12 Nov 2024 12:15:06 +0100 (CET), Geert Uytterhoeven wrote:
>  	Hi Jean, Vincent,
> 
> On Tue, 22 Oct 2024, Vincent MAILHOL wrote:
> > On Tue. 22 Oct. 2024 at 20:06, Jean Delvare <jdelvare@suse.de> wrote:  
> >> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), OF
> >> can be enabled on all architectures. Therefore depending on
> >> COMPILE_TEST as an alternative is no longer needed.  
> >
> > I understand the motivation behind this patch, but for me, as a
> > maintainer, it becomes more work when I want to do a compile test.
> > Before I would have needed to only select COMPILE_TEST but now, I
> > would need to remember to also select OF for that driver to appear in
> > the menuconfig.  
> 
> IMHO these are two different things: to get a working driver, you need
> to enable OF;

True.

>(...) to do (may be limited, i.e. may not give a working driver)
> compile-testing, you need to enable COMPILE_TEST.

No, you don't *need* it. Enabling COMPILE_TEST is (or was) one way to
do compile-testing, but it was not the only way. Which is the reason
why it was dropped.

Your reasoning would hold only if building a limited, maybe not-working
driver, was a purpose in itself. I personally can't see any value in
doing this.

-- 
Jean Delvare
SUSE L3 Support