Re: [PATCH] can: rockchip_canfd: Drop obsolete dependency on COMPILE_TEST

[Geert Uytterhoeven <geert@linux-m68k.org>]

 	Hi Jean, Vincent,

On Tue, 22 Oct 2024, Vincent MAILHOL wrote:
> On Tue. 22 Oct. 2024 at 20:06, Jean Delvare <jdelvare@suse.de> wrote:
>> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), OF
>> can be enabled on all architectures. Therefore depending on
>> COMPILE_TEST as an alternative is no longer needed.
>
> I understand the motivation behind this patch, but for me, as a
> maintainer, it becomes more work when I want to do a compile test.
> Before I would have needed to only select COMPILE_TEST but now, I
> would need to remember to also select OF for that driver to appear in
> the menuconfig.

IMHO these are two different things: to get a working driver, you need
to enable OF; to do (may be limited, i.e. may not give a working driver)
compile-testing, you need to enable COMPILE_TEST.

So I think commit 51e102ec23b25e6c ("can: rockchip_canfd: Drop obsolete
dependency on COMPILE_TEST") should be reverted.

> Well, I am not strongly against this simplification, but, wouldn't it
> be good to make COMPILE_TEST automatically select OF then? Looking at
> the description of COMPILE_TEST, I read:
>
> If you are a developer and want to build everything available, say Y here.
>
> So having COMPILE_TEST automatically select OF looks sane to me as it
> goes in the direction of "building everything". If this makes sense, I
> can send a patch for this. Thoughts?

Please don't do that! Merely enabling COMPILE_TEST should not enable
any additional code in the kernel.

>> --- linux-6.12-rc4.orig/drivers/net/can/rockchip/Kconfig
>> +++ linux-6.12-rc4/drivers/net/can/rockchip/Kconfig
>> @@ -2,7 +2,7 @@
>>
>>  config CAN_ROCKCHIP_CANFD
>>         tristate "Rockchip CAN-FD controller"
>> -       depends on OF || COMPILE_TEST
>> +       depends on OF
>>         select CAN_RX_OFFLOAD
>>         help
>>           Say Y here if you want to use CAN-FD controller found on
>>

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds