Re: [PATCH 1/2] dt-bindings: can: add arasan canfd controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The schema uses `additionalProperties: false` instead of `unevaluatedProperties: false`, which breaks property inheritance from `can-controller.yaml`.
- [Medium] Missing `clock-names` and `reset-names` in the `required` list, and missing `minItems` constraints.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: can: add arasan canfd controller ---
commit 282ace981cf63f65fd400dda84f1806d370fbc9b
Author: Jisheng Zhang <jszhang@kernel.org>

dt-bindings: can: add arasan canfd controller

This commit adds device tree binding documentation for the Arasan CAN-FD
controller.

> diff --git a/Documentation/devicetree/bindings/net/can/arasan,canfd.yaml b/Documentation/devicetree/bindings/net/can/arasan,canfd.yaml
> new file mode 100644
> index 0000000000000..a120c11ce3045
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/arasan,canfd.yaml
[ ... ]
> +allOf:
> +  - $ref: can-controller.yaml#
[ ... ]
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: can
> +      - const: sys
> +
> +  resets:
> +    maxItems: 2
> +
> +  reset-names:
> +    items:
> +      - const: can
> +      - const: sys
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - resets

[Severity: Medium]
Should clock-names and reset-names be included in this required list? A device
tree omitting these names might pass validation, but could cause the driver to
fail during probe when requesting clocks or resets by name.

Also, should clocks and resets specify minItems: 2, since the definition
expects two distinct items for each?

> +
> +additionalProperties: false

[Severity: Medium]
Should this use unevaluatedProperties: false instead? Since the schema includes
can-controller.yaml via $ref earlier in the file, using additionalProperties:
false will prevent the inheritance of valid standard properties from the
included schema.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803140531.12692-1-jszhang@kernel.org?part=1