Re: [PATCH 1/2] dt-bindings: can: add arasan canfd controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/08/2026 16:05, Jisheng Zhang wrote:
> Add documentation for the arasan canfd controller.

Here goes hardware description. What is arasan canfd?

> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  .../bindings/net/can/arasan,canfd.yaml        | 63 +++++++++++++++++++
>  1 file changed, 63 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/can/arasan,canfd.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/can/arasan,canfd.yaml b/Documentation/devicetree/bindings/net/can/arasan,canfd.yaml
> new file mode 100644
> index 000000000000..a120c11ce304
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/arasan,canfd.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/arasan,canfd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title:
> +  Arasan CAN-FD controller
> +
> +maintainers:
> +  - Jisheng Zhang <jszhang@kernel.org>
> +
> +allOf:
> +  - $ref: can-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: arasan,canfd

This is way too generic. Why isn't there any integration compatible?

Please follow writing bindings.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2

Instead list and describe items

> +
> +  clock-names:
> +    items:
> +      - const: can

can is too generic, not really useful. Same for resets.


Best regards,
Krzysztof