[PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

Add support for Renesas RZ/G3L CANFD.
The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2 channels
and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers compared to 192
buffers on RZ/G3S SoC.

This patch series depend upon [1]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626

v4->v5:
 * Added patches for Documenting RZ/G3{L,S} SoC has no Classical CAN mode.
 * Dropped the patch "can: rcar_canfd: Derive max_channels from the device
   tree"
 * Dropped the tags as there are new changes.
 * Restored maxItems on interrupts and interrupt-names.
 * Added resets/reset-names required property for RZ/G3L.
 * Added r9a08g046_hw_info to device data.
v3->v4:
 * Dropped maxItems from interrupts,interrupt-names and resets.
 * Collected tags.
v2->v3:
 * Collected tags.
 * Added check against RCANFD_NUM_CHANNELS, to avoid overrunning the
   fixed-size rcar_canfd_global.ch[] and transceivers[] arrays.
 * Fixed typo 198->192 buffers in commit description.
v1->v2:
 * Added support for deriving max_channels from the device tree.
 * Dropped clock patch as it is accepted.
 * Dropped devicetree patches, will send it later.
 * Updated commit description
 * Dropped RZ/G3S fallback as there are lot of differences.


Biju Das (4):
  dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical
    CAN mode
  can: rcar_canfd: Document that RZ/G3S has no Classical CAN mode
  dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC
  can: rcar_canfd: Add support for Renesas RZ/G3L

 .../bindings/net/can/renesas,rcar-canfd.yaml  | 32 +++++++++++++++++--
 drivers/net/can/rcar/rcar_canfd.c             | 31 +++++++++++++++---
 2 files changed, 55 insertions(+), 8 deletions(-)

-- 
2.43.0

[PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

The description of the property that selects Classical CAN mode implies
that every supported SoC can operate in that mode. This is not true for
RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.

Update the description to say that Classical CAN mode is not available on
RZ/G3S, so the property is not mistakenly used for that SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v5:
 * New patch.
---
 .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 1a7a9ce45e97..7d3330f8fc1a 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -146,8 +146,8 @@ properties:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
       The controller can operate in either CAN-FD mode (default) or FD-Only
-      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
-      property to put the controller in Classical CAN mode.
+      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
+      Specify this property to put the controller in Classical CAN mode.
 
   renesas,fd-only:
     $ref: /schemas/types.yaml#/definitions/flag
-- 
2.43.0

[PATCH v5 2/4] can: rcar_canfd: Document that RZ/G3S has no Classical CAN mode

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

The header comments in the driver describe Classical CAN (CAN 2.0)
only mode as a mode the controller can operate in, without saying that
this does not apply to every supported SoC. RZ/G3S does not support
Classical CAN mode.

Update the comments to note the RZ/G3S exception, so that readers of
the driver are not misled about which SoCs can use that mode. This
matches the corresponding dt-bindings update.

No functional change.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v5:
 * New patch.
---
 drivers/net/can/rcar/rcar_canfd.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
index 74c3c3f20991..86fa88ccf63b 100644
--- a/drivers/net/can/rcar/rcar_canfd.c
+++ b/drivers/net/can/rcar/rcar_canfd.c
@@ -6,7 +6,7 @@
 
 /* The R-Car CAN FD controller can operate in either one of the below two modes
  *  - CAN FD only mode
- *  - Classical CAN (CAN 2.0) only mode
+ *  - Classical CAN (CAN 2.0) only mode (Except RZ/G3S)
  *
  * This driver puts the controller in CAN FD only mode by default. In this
  * mode, the controller acts as a CAN FD node that can also interoperate with
@@ -247,10 +247,10 @@
 #define RCANFD_CFFDCSTS_CFBRS		BIT(1)
 #define RCANFD_CFFDCSTS_CFESI		BIT(0)
 
-/* This controller supports either Classical CAN only mode or CAN FD only mode.
- * These modes are supported in two separate set of register maps & names.
- * However, some of the register offsets are common for both modes. Those
- * offsets are listed below as Common registers.
+/* This controller supports either Classical CAN only mode(Except RZ/G3S) or
+ * CAN FD only mode. These modes are supported in two separate set of register
+ * maps & names. However, some of the register offsets are common for both
+ * modes. Those offsets are listed below as Common registers.
  *
  * The CAN FD only mode specific registers & Classical CAN only mode specific
  * registers are listed separately. Their register names starts with
-- 
2.43.0

[PATCH v5 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

Document the RZ/G3L (R9A08G046) SoC support.

RZ/G3L has 11 interrupts and 3 CANFD channels compared to 8 interrupts
and 2 CANFD channels on RZ/G3S. RZ/G3L has 288 buffers in total
compared to 192 buffers in RZ/G3S.

Like RZ/G3S, RZ/G3L supports only CAN-FD mode, so renesas,no-can-fd is
disallowed for it, and the description of that property is updated to
exclude RZ/G3L.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v4->v5:
 * Dropped the tags as there are new changes.
 * Updated the description for renesas,no-can-fd to document RZ/G3L has no
   Classical CAN mode.
 * Restored maxItems on interrupts and interrupt-names.
 * Added resets/reset-names required property for RZ/G3L.
v3->v4:
 * Dropped maxItems from interrupts,interrupt-names and resets.
 * Collected tag.
v2->v3:
 * Collected tag.
v1->v2:
 * Updated commit description
 * Dropped RZ/G3S fallback as there are lot of differences.
---
 .../bindings/net/can/renesas,rcar-canfd.yaml  | 32 +++++++++++++++++--
 1 file changed, 29 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 7d3330f8fc1a..22980ee1e898 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -14,6 +14,7 @@ properties:
     oneOf:
       - enum:
           - renesas,r9a08g045-canfd        # RZ/G3S
+          - renesas,r9a08g046-canfd        # RZ/G3L
           - renesas,r9a09g047-canfd        # RZ/G3E
           - renesas,r9a09g077-canfd        # RZ/T2H
 
@@ -146,8 +147,9 @@ properties:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
       The controller can operate in either CAN-FD mode (default) or FD-Only
-      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
-      Specify this property to put the controller in Classical CAN mode.
+      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3L
+      and RZ/G3S). Specify this property to put the controller in Classical CAN
+      mode.
 
   renesas,fd-only:
     $ref: /schemas/types.yaml#/definitions/flag
@@ -294,6 +296,27 @@ allOf:
       patternProperties:
         "^channel[6-7]$": false
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: renesas,r9a08g046-canfd
+    then:
+      properties:
+        interrupts:
+          minItems: 11
+          maxItems: 11
+
+        interrupt-names:
+          minItems: 11
+          maxItems: 11
+
+        resets:
+          minItems: 2
+
+      patternProperties:
+        "^channel[3-7]$": false
+
   - if:
       properties:
         compatible:
@@ -334,6 +357,7 @@ allOf:
           contains:
             enum:
               - renesas,r9a08g045-canfd
+              - renesas,r9a08g046-canfd
               - renesas,r9a09g047-canfd
               - renesas,rzg2l-canfd
     then:
@@ -358,7 +382,9 @@ allOf:
       properties:
         compatible:
           contains:
-            const: renesas,r9a08g045-canfd
+            enum:
+              - renesas,r9a08g045-canfd
+              - renesas,r9a08g046-canfd
     then:
       properties:
         renesas,no-can-fd: false
-- 
2.43.0

[PATCH v5 4/4] can: rcar_canfd: Add support for Renesas RZ/G3L

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

Add support for Renesas RZ/G3L CANFD IP. RZ/G3L has 3 channels and
11 interrupts, compared 2 channels and 8 interrupts on RZ/G3S.
RZ/G3L has 288 buffers compared to 192 buffers on RZ/G3S.

Like RZ/G3S, the controller supports only CAN-FD mode and update
the comments to note that Classical CAN mode is not available on
RZ/G3L either.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v4->v5:
 * Dropped the tags as there are new changes.
 * Documented Classical CAN mode is not available on RZ/G3L.
 * Added r9a08g046_hw_info to device data.
v3->v4:
 * Collected the tag.
v2->v3:
 * Fixed the typo 198->192 buffers in commit description.
 * Collected the tag.
v1->v2:
 * Updated commit description
 * Dropped RZ/G3S fallback
---
 drivers/net/can/rcar/rcar_canfd.c | 31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
index 86fa88ccf63b..0da2fefb047b 100644
--- a/drivers/net/can/rcar/rcar_canfd.c
+++ b/drivers/net/can/rcar/rcar_canfd.c
@@ -6,7 +6,7 @@
 
 /* The R-Car CAN FD controller can operate in either one of the below two modes
  *  - CAN FD only mode
- *  - Classical CAN (CAN 2.0) only mode (Except RZ/G3S)
+ *  - Classical CAN (CAN 2.0) only mode (Except RZ/G3{L,S})
  *
  * This driver puts the controller in CAN FD only mode by default. In this
  * mode, the controller acts as a CAN FD node that can also interoperate with
@@ -247,10 +247,10 @@
 #define RCANFD_CFFDCSTS_CFBRS		BIT(1)
 #define RCANFD_CFFDCSTS_CFESI		BIT(0)
 
-/* This controller supports either Classical CAN only mode(Except RZ/G3S) or
- * CAN FD only mode. These modes are supported in two separate set of register
- * maps & names. However, some of the register offsets are common for both
- * modes. Those offsets are listed below as Common registers.
+/* This controller supports either Classical CAN only mode(Except RZ/G3{L,S})
+ * or CAN FD only mode. These modes are supported in two separate set of
+ * register maps & names. However, some of the register offsets are common for
+ * both modes. Those offsets are listed below as Common registers.
  *
  * The CAN FD only mode specific registers & Classical CAN only mode specific
  * registers are listed separately. Their register names starts with
@@ -681,6 +681,26 @@ static const struct rcar_canfd_hw_info r9a08g045_hw_info = {
 	.fixed_canfd = 1,
 };
 
+static const struct rcar_canfd_hw_info r9a08g046_hw_info = {
+	.nom_bittiming = &rcar_canfd_gen4_nom_bittiming_const,
+	.data_bittiming = &rcar_canfd_gen4_data_bittiming_const,
+	.tdc_const = &rcar_canfd_gen4_tdc_const,
+	.regs = &rcar_gen4_regs,
+	.sh = &rcar_gen4_shift_data,
+	.rnc_field_width = 16,
+	.max_aflpn = 15,
+	.max_cftml = 31,
+	.max_channels = 3,
+	.postdiv = 2,
+	.shared_global_irqs = 0,
+	.multi_channel_irqs = 1,
+	.ch_interface_mode = 1,
+	.shared_can_regs = 1,
+	.external_clk = 1,
+	.fcan_pclk = 1,
+	.fixed_canfd = 1,
+};
+
 static const struct rcar_canfd_hw_info r9a09g047_hw_info = {
 	.nom_bittiming = &rcar_canfd_gen4_nom_bittiming_const,
 	.data_bittiming = &rcar_canfd_gen4_data_bittiming_const,
@@ -2404,6 +2424,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(rcar_canfd_pm_ops, rcar_canfd_suspend,
 static const __maybe_unused struct of_device_id rcar_canfd_of_table[] = {
 	{ .compatible = "renesas,r8a779a0-canfd", .data = &rcar_gen4_hw_info },
 	{ .compatible = "renesas,r9a08g045-canfd", .data = &r9a08g045_hw_info },
+	{ .compatible = "renesas,r9a08g046-canfd", .data = &r9a08g046_hw_info },
 	{ .compatible = "renesas,r9a09g047-canfd", .data = &r9a09g047_hw_info },
 	{ .compatible = "renesas,r9a09g077-canfd", .data = &r9a09g077_hw_info },
 	{ .compatible = "renesas,rcar-gen3-canfd", .data = &rcar_gen3_hw_info },
-- 
2.43.0

Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Krzysztof Kozlowski]

On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Add support for Renesas RZ/G3L CANFD.
> The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2 channels
> and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers compared to 192
> buffers on RZ/G3S SoC.
> 
> This patch series depend upon [1]
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> 
> v4->v5:

b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
Checking for older revisions
Grabbing search results from lore.kernel.org
---
Analyzing 5 messages in the thread
Could not find lower series to compare against.

I do not get why you keep making things difficult for review, but it's
your right. I'll skip the patch for some time.

Best regards,
Krzysztof

RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Biju Das]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 20 October 2026 09:13
> Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> 
> On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Add support for Renesas RZ/G3L CANFD.
> > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2
> > channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers
> > compared to 192 buffers on RZ/G3S SoC.
> >
> > This patch series depend upon [1]
> > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
> > /commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> >
> > v4->v5:
> 
> b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> ---
> Analyzing 5 messages in the thread
> Could not find lower series to compare against.
> 
> I do not get why you keep making things difficult for review, but it's your right. I'll skip the patch
> for some time.

Sorry for that, I was not aware switching the mail ID will impact the b4.

Here is previous version[1], please let me know if you want me to resend the
same series with previous mail ID. I am happy to resend.

[1]
https://lore.kernel.org/all/20261001075742.21961-1-biju.das.jz@bp.renesas.com/ 

Cheers,
Biju

Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Add support for Renesas RZ/G3L CANFD.
> > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2 channels
> > and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers compared to 192
> > buffers on RZ/G3S SoC.
> >
> > This patch series depend upon [1]
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> >
> > v4->v5:
>
> b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> ---
> Analyzing 5 messages in the thread
> Could not find lower series to compare against.
>
> I do not get why you keep making things difficult for review, but it's
> your right. I'll skip the patch for some time.

If you use b4 [1] for sending patches, you make things a lot easier for
the reviewers (and yourself).

regards,
Marc

[1] https://b4.docs.kernel.org/en/latest/

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Biju Das]

Hi Marc/Krzysztof,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 20 October 2026 09:21
> Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> 
> On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> > On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > Add support for Renesas RZ/G3L CANFD.
> > > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2
> > > channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers
> > > compared to 192 buffers on RZ/G3S SoC.
> > >
> > > This patch series depend upon [1]
> > > [1]
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.g
> > > it/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> > >
> > > v4->v5:
> >
> > b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> > Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> > Checking for older revisions
> > Grabbing search results from lore.kernel.org
> > ---
> > Analyzing 5 messages in the thread
> > Could not find lower series to compare against.
> >
> > I do not get why you keep making things difficult for review, but it's
> > your right. I'll skip the patch for some time.
> 
> If you use b4 [1] for sending patches, you make things a lot easier for the reviewers (and yourself).

Thanks for the pointer. So far, I use "git send-email --annotate *.patch" to send the patches. I need to explore
how to send the patches using b4.

Cheers,
Biju  

> 
> [1] https://b4.docs.kernel.org/en/latest/

RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Biju Das]

Hi Marc/Krzysztof,

> -----Original Message-----
> From: Biju Das
> Sent: 20 October 2026 09:31
> Subject: RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> 
> Hi Marc/Krzysztof,
> 
> > -----Original Message-----
> > From: Marc Kleine-Budde <mkl@pengutronix.de>
> > Sent: 20 October 2026 09:21
> > Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> >
> > On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> > > On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > >
> > > > Add support for Renesas RZ/G3L CANFD.
> > > > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2
> > > > channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers
> > > > compared to 192 buffers on RZ/G3S SoC.
> > > >
> > > > This patch series depend upon [1]
> > > > [1]
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next
> > > > .g
> > > > it/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> > > >
> > > > v4->v5:
> > >
> > > b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> > > Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> > > Checking for older revisions
> > > Grabbing search results from lore.kernel.org
> > > ---
> > > Analyzing 5 messages in the thread
> > > Could not find lower series to compare against.
> > >
> > > I do not get why you keep making things difficult for review, but
> > > it's your right. I'll skip the patch for some time.
> >
> > If you use b4 [1] for sending patches, you make things a lot easier for the reviewers (and yourself).
> 
> Thanks for the pointer. So far, I use "git send-email --annotate *.patch" to send the patches. I need to
> explore how to send the patches using b4.

I have explored b4. Maybe I can resend the series with b4. But unfortunately, since it is forced version v5,
b4 diff <msg id v5> won't work like whatever Krzysztof tried.

Please let me know.

V5: https://lore.kernel.org/all/20261019120220.166163-1-biju.das.jz@bp.renesas.com/

V4: https://lore.kernel.org/all/20261001075742.21961-1-biju.das.jz@bp.renesas.com/T/#t

Cheers,
Biju

RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD

[Biju Das]

Hi Krzysztof,

> -----Original Message-----
> From: Biju Das
> Sent: 20 October 2026 13:33
> Subject: RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> 
> Hi Marc/Krzysztof,
> 
> > -----Original Message-----
> > From: Biju Das
> > Sent: 20 October 2026 09:31
> > Subject: RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> >
> > Hi Marc/Krzysztof,
> >
> > > -----Original Message-----
> > > From: Marc Kleine-Budde <mkl@pengutronix.de>
> > > Sent: 20 October 2026 09:21
> > > Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> > >
> > > On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> > > > On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > > >
> > > > > Add support for Renesas RZ/G3L CANFD.
> > > > > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to
> > > > > 2 channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288
> > > > > buffers compared to 192 buffers on RZ/G3S SoC.
> > > > >
> > > > > This patch series depend upon [1] [1]
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-ne
> > > > > xt
> > > > > .g
> > > > > it/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> > > > >
> > > > > v4->v5:
> > > >
> > > > b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> > > > Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> > > > Checking for older revisions
> > > > Grabbing search results from lore.kernel.org
> > > > ---
> > > > Analyzing 5 messages in the thread Could not find lower series to
> > > > compare against.
> > > >
> > > > I do not get why you keep making things difficult for review, but
> > > > it's your right. I'll skip the patch for some time.
> > >
> > > If you use b4 [1] for sending patches, you make things a lot easier for the reviewers (and yourself).
> >
> > Thanks for the pointer. So far, I use "git send-email --annotate
> > *.patch" to send the patches. I need to explore how to send the patches using b4.
> 
> I have explored b4. Maybe I can resend the series with b4. But unfortunately, since it is forced version
> v5,
> b4 diff <msg id v5> won't work like whatever Krzysztof tried.
> 
> Please let me know.
> 
> V5: https://lore.kernel.org/all/20261019120220.166163-1-biju.das.jz@bp.renesas.com/
> 
> V4: https://lore.kernel.org/all/20261001075742.21961-1-biju.das.jz@bp.renesas.com/T/#t

FYI, Just attaching b4 diff equivalent between the 2 versions

biju@biju:~/linux-next-upstream-b4$ git range-diff master..b4/b4-canfd_rzg3l_v4 master..b4/canfd_rzg3l
 1:  b0f7cbbdc009 =  1:  49d37ce91cae dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC
 2:  89fadc83f0ba =  2:  5b845af145c4 can: rcar_canfd: Fix typos in macro names
 3:  d50639abd4ad =  3:  489d1144599f can: rcar_canfd: Allow the CAN FD clock to be sourced from fck
 4:  e95baeb6b106 =  4:  748ae017c40b can: rcar_canfd: Do not set registers selecting the CAN mode
 5:  8e9a5b56fc82 =  5:  326f8dd1b40c can: rcar_canfd: Add support for Renesas RZ/G3S
 6:  967dc8e78108 =  6:  ef2fff76f761 dt-bindings: can: renesas,rcar-canfd: Restrict resets in top-level
 7:  2a8901b450a9 <  -:  ------------ Add support for Renesas RZ/G3L CANFD.
 -:  ------------ >  7:  7a1167fb59af Add support for Renesas RZ/G3L CANFD
 -:  ------------ >  8:  0577b28d55c0 dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode
 -:  ------------ >  9:  a7643a14339f can: rcar_canfd: Document that RZ/G3S has no Classical CAN mode
 8:  3b72a5072b77 ! 10:  0e5f2c6ff23c dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC
    @@ Commit message
         and 2 CANFD channels on RZ/G3S. RZ/G3L has 288 buffers in total
         compared to 192 buffers in RZ/G3S.
     
    -    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    -    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
    -    Link: https://patch.msgid.link/20261001075742.21961-2-biju.das.jz@bp.renesas.com
    +    Like RZ/G3S, RZ/G3L supports only CAN-FD mode, so renesas,no-can-fd is
    +    disallowed for it, and the description of that property is updated to
    +    exclude RZ/G3L.
    +
         Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
         ---
    +    v4->v5:
    +     * Dropped the tags as there are new changes.
    +     * Updated the description for renesas,no-can-fd to document RZ/G3L has no
    +       Classical CAN mode.
    +     * Restored maxItems on interrupts and interrupt-names.
    +     * Added resets/reset-names required property for RZ/G3L.
         v3->v4:
          * Dropped maxItems from interrupts,interrupt-names and resets.
          * Collected tag.
    @@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: properties:
                - renesas,r9a09g047-canfd        # RZ/G3E
                - renesas,r9a09g077-canfd        # RZ/T2H
      
    +@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: properties:
    +     $ref: /schemas/types.yaml#/definitions/flag
    +     description:
    +       The controller can operate in either CAN-FD mode (default) or FD-Only
    +-      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
    +-      Specify this property to put the controller in Classical CAN mode.
    ++      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3L
    ++      and RZ/G3S). Specify this property to put the controller in Classical CAN
    ++      mode.
    + 
    +   renesas,fd-only:
    +     $ref: /schemas/types.yaml#/definitions/flag
     @@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
            patternProperties:
              "^channel[6-7]$": false
    @@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
     +      properties:
     +        interrupts:
     +          minItems: 11
    ++          maxItems: 11
     +
     +        interrupt-names:
     +          minItems: 11
    ++          maxItems: 11
     +
     +        resets:
     +          minItems: 2
    @@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
        - if:
            properties:
              compatible:
    +@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
    +           contains:
    +             enum:
    +               - renesas,r9a08g045-canfd
    ++              - renesas,r9a08g046-canfd
    +               - renesas,r9a09g047-canfd
    +               - renesas,rzg2l-canfd
    +     then:
     @@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
            properties:
              compatible:
 9:  5481bef4417d <  -:  ------------ can: rcar_canfd: Derive max_channels from the device tree
10:  bef7311050db <  -:  ------------ can: rcar_canfd: Add support for Renesas RZ/G3L
 -:  ------------ > 11:  b756a10a565a can: rcar_canfd: Add support for Renesas RZ/G3L

Cheers,
Biju

Re: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode

[Rob Herring]

On Mon, Oct 19, 2026 at 01:02:13PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> The description of the property that selects Classical CAN mode implies
> that every supported SoC can operate in that mode. This is not true for
> RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.
> 
> Update the description to say that Classical CAN mode is not available on
> RZ/G3S, so the property is not mistakenly used for that SoC.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v5:
>  * New patch.
> ---
>  .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 1a7a9ce45e97..7d3330f8fc1a 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -146,8 +146,8 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
>        The controller can operate in either CAN-FD mode (default) or FD-Only
> -      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
> -      property to put the controller in Classical CAN mode.
> +      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
> +      Specify this property to put the controller in Classical CAN mode.

Can't this be expressed as a schema?

>  
>    renesas,fd-only:
>      $ref: /schemas/types.yaml#/definitions/flag
> -- 
> 2.43.0
> 

RE: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode

[Biju Das]

Hi Rob,

Thanks for the feedback.

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 20 October 2026 17:49
> Subject: Re: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN
> mode
> 
> On Mon, Oct 19, 2026 at 01:02:13PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > The description of the property that selects Classical CAN mode
> > implies that every supported SoC can operate in that mode. This is not
> > true for RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.
> >
> > Update the description to say that Classical CAN mode is not available
> > on RZ/G3S, so the property is not mistakenly used for that SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v5:
> >  * New patch.
> > ---
> >  .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml       | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > index 1a7a9ce45e97..7d3330f8fc1a 100644
> > ---
> > a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yam
> > +++ l
> > @@ -146,8 +146,8 @@ properties:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description:
> >        The controller can operate in either CAN-FD mode (default) or FD-Only
> > -      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
> > -      property to put the controller in Classical CAN mode.
> > +      mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
> > +      Specify this property to put the controller in Classical CAN mode.
> 
> Can't this be expressed as a schema?

OK.  I'll express this in the schema with an if/then that disallows renesas,no-can-fd for renesas,r9a08g045-canfd, and Will update the description as "Specify this property to put the controller in Classical CAN mode"
and will remove the unwanted description "The controller can operate in either CAN-FD mode (default) or FD-Only mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode."

  - if:
      properties:
        compatible:
          contains:
            const: renesas,r9a08g045-canfd
    then:
      properties:
        renesas,no-can-fd: false

Cheers,
Biju